Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute accounting circuit breaker check after test #42448

Merged
merged 1 commit into from
May 23, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented May 23, 2019

If we close an engine while a refresh is happening, then we might leak refCount of some SegmentReaders. We need to skip the ram accounting circuit breaker check until we have a new Lucene snapshot which includes the fix https://issues.apache.org/jira/browse/LUCENE-8809.

I added a test to the engine but left it muted so we won't forget to reenable this check.

Closes #30290

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 v7.2.0 v6.8.1 v7.1.1 labels May 23, 2019
@dnhatn dnhatn requested review from dakrone, jpountz and s1monw May 23, 2019 15:06
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for finding this Nhat

@dnhatn
Copy link
Member Author

dnhatn commented May 23, 2019

Thanks @dakrone.

@dnhatn dnhatn merged commit 4bec333 into elastic:master May 23, 2019
@dnhatn dnhatn deleted the mute-accouting-breaker branch May 23, 2019 17:27
@jpountz jpountz added v7.1.2 and removed v7.1.1 labels May 24, 2019
dnhatn added a commit that referenced this pull request May 24, 2019
If we close an engine while a refresh is happening, then we might leak
refCount of some SegmentReaders. We need to skip the ram accounting
circuit breaker check until we have a new Lucene snapshot which includes
the fix for LUCENE-8809.

This also adds a test to the engine but left it muted so we won't forget
to reenable this check.

Closes #30290
dnhatn added a commit that referenced this pull request May 24, 2019
If we close an engine while a refresh is happening, then we might leak
refCount of some SegmentReaders. We need to skip the ram accounting
circuit breaker check until we have a new Lucene snapshot which includes
the fix for LUCENE-8809.

This also adds a test to the engine but left it muted so we won't forget
to reenable this check.

Closes #30290
dnhatn added a commit that referenced this pull request May 24, 2019
If we close an engine while a refresh is happening, then we might leak
refCount of some SegmentReaders. We need to skip the ram accounting
circuit breaker check until we have a new Lucene snapshot which includes
the fix for LUCENE-8809.

This also adds a test to the engine but left it muted so we won't forget
to reenable this check.

Closes #30290
dnhatn added a commit that referenced this pull request May 25, 2019
If we close an engine while a refresh is happening, then we might leak
refCount of some SegmentReaders. We need to skip the ram accounting
circuit breaker check until we have a new Lucene snapshot which includes
the fix for LUCENE-8809.

This also adds a test to the engine but left it muted so we won't forget
to reenable this check.

Relates #30290
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
If we close an engine while a refresh is happening, then we might leak
refCount of some SegmentReaders. We need to skip the ram accounting
circuit breaker check until we have a new Lucene snapshot which includes
the fix for LUCENE-8809.

This also adds a test to the engine but left it muted so we won't forget
to reenable this check.

Closes elastic#30290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test Issues or PRs that are addressing/adding tests v6.8.1 v7.1.2 v7.2.0 v7.3.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] AssertionError: Accounting breaker not reset
5 participants