[ML Data Frame] Reenable muted integration tests #42373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkyle
added
>test
|
Pinging @elastic/ml-core |
davidkyle
force-pushed
the
improve-testing
branch
from
35bc230 to
1494f1e
Compare
przemekwitek
approved these changes
May 23, 2019
|
retest this please |
This reverts commit 4a94387.
davidkyle
force-pushed
the
improve-testing
branch
from
1494f1e to
fd23c39
Compare
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Reverts muting of tests and simplifies the test teardown so that all data frames will be stopped This reverts commit 4a94387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42344 looks like catastrophic failures but the root cause was #42347.
The reason the pending tasks were not terminated is in the clean up code which would iterate over each data frame, stop it and assert that its state == stopped. #42347 meant that the state was reported incorrectly. If there was more than one data frame created in the test then others would not be stopped due to the assertion being thrown inside the for loop.
elasticsearch/x-pack/plugin/data-frame/qa/single-node-tests/src/test/java/org/elasticsearch/xpack/dataframe/integration/DataFrameRestTestCase.java
Line 306 in 7c503ce
I've changed the logic to stop all data frames before assert that they are in state stopped and re-enabled the tests as the root cause was fixed in #42347.
Closes #42344