Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML Data Frame] Account for completed data frames in test #42351

Merged
merged 3 commits into from
May 23, 2019

Conversation

davidkyle
Copy link
Member

When asserting on the checkpoint value if the DF has completed the checkpoint may be 1. Similarly state may be started or indexing.

Closes #42309, depends on #42347

@davidkyle davidkyle added >test Issues or PRs that are addressing/adding tests v8.0.0 v7.2.0 :ml/Transform Transform labels May 22, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@przemekwitek przemekwitek self-requested a review May 22, 2019 12:55
Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle davidkyle merged commit da77b97 into elastic:master May 23, 2019
@davidkyle davidkyle deleted the fix-df-yml-tests branch May 23, 2019 07:42
davidkyle added a commit that referenced this pull request May 23, 2019
When asserting on the checkpoint value if the DF has completed the checkpoint will be 1 else 0.
Similarly state may be started or indexing. Closes #42309
davidkyle added a commit that referenced this pull request May 23, 2019
When asserting on the checkpoint value if the DF has completed the checkpoint will be 1 else 0.
Similarly state may be started or indexing. Closes #42309
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
)

When asserting on the checkpoint value if the DF has completed the checkpoint will be 1 else 0.
Similarly state may be started or indexing. Closes elastic#42309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml/Transform Transform >test Issues or PRs that are addressing/adding tests v7.2.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transforms_stats#"Test Get Transform Stats" fails because pages_processed/checkpoint don't match
4 participants