Some Cleanup in o.e.i.engine #42278
Merged
Some Cleanup in o.e.i.engine #42278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove dead code and parameters * Reduce visibility in some obvious spots * Add missing `assert`s (not that important here since the methods themselves will proably be dead-code eliminated) but still
original-brownbear
added
>non-issue
:Distributed Indexing/Engine
|
Pinging @elastic/es-distributed |
|
Jenkins run elasticsearch-ci/2 |
|
Jenkins run elasticsearch-ci/bwc |
jpountz
approved these changes
May 22, 2019
| return new IndexingStrategy(true, true, true, | ||
| false, versionForIndexing, null); | ||
| false, (long) 1, null); |
| @@ -457,8 +457,8 @@ public void updateMaxUnsafeAutoIdTimestamp(long newTimestamp) { | |||
|
|
|||
| } | |||
|
|
|||
| protected void processReaders(IndexReader reader, IndexReader previousReader) { | |||
| searcherFactory.processReaders(reader, previousReader); | |||
| protected void processReaders(IndexReader reader) { | |||
There was a problem hiding this comment.
maybe rename the method as well since we have a single reader now?
| @@ -59,7 +59,7 @@ public CodecReader wrapForMerge(CodecReader reader) throws IOException { | |||
| } | |||
|
|
|||
| // pkg private for testing | |||
| static CodecReader wrapReader(String recoverySourceField, CodecReader reader, Supplier<Query> retainSourceQuerySupplier) | |||
| private static CodecReader wrapReader(String recoverySourceField, CodecReader reader, Supplier<Query> retainSourceQuerySupplier) | |||
There was a problem hiding this comment.
remove the above comment now?
|
thanks @jpountz ! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
May 27, 2019
* Some Cleanup in o.e.i.engine * Remove dead code and parameters * Reduce visibility in some obvious spots * Add missing `assert`s (not that important here since the methods themselves will probably be dead-code eliminated) but still
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* Some Cleanup in o.e.i.engine * Remove dead code and parameters * Reduce visibility in some obvious spots * Add missing `assert`s (not that important here since the methods themselves will probably be dead-code eliminated) but still
original-brownbear
added a commit
that referenced
this pull request
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asserts (not that important here since the methodsthemselves will probably be dead-code eliminated) but still