Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] fix concurrency bug in AsyncTwoPhaseIndexerTests #42275

Merged
merged 1 commit into from
May 22, 2019

Conversation

hendrikmuhs
Copy link

move latch await to doNextSearch, fixes a race condition when the executor thread is faster than the coordinator thread

fixes #42084

@hendrikmuhs hendrikmuhs added >test Issues or PRs that are addressing/adding tests :ml Machine learning :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data v8.0.0 v7.2.0 labels May 21, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrikmuhs
Copy link
Author

run elasticsearch-ci/2
run elasticsearch-ci/bwc
run elasticsearch-ci/default-distro

@hendrikmuhs
Copy link
Author

run elasticsearch-ci/2
run elasticsearch-ci/bwc

@hendrikmuhs
Copy link
Author

run elasticsearch-ci/2

@hendrikmuhs hendrikmuhs merged commit 9a152ee into elastic:master May 22, 2019
hendrikmuhs pushed a commit that referenced this pull request May 22, 2019
move latch await to doNextSearch, fixes a race condition when the executor thread is faster than the coordinator thread

fixes #42084
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
move latch await to doNextSearch, fixes a race condition when the executor thread is faster than the coordinator thread

fixes elastic#42084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data >test Issues or PRs that are addressing/adding tests v7.2.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncTwoPhaseIndexerTests failure
4 participants