-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] fix concurrency bug in AsyncTwoPhaseIndexerTests #42275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs
added
>test
Issues or PRs that are addressing/adding tests
:ml
Machine learning
:StorageEngine/Rollup
Turn fine-grained time-based data into coarser-grained data
v8.0.0
v7.2.0
labels
May 21, 2019
Pinging @elastic/ml-core |
Pinging @elastic/es-analytics-geo |
hendrikmuhs
force-pushed
the
testfix-#42084
branch
from
May 21, 2019 06:24
50f2864
to
ad2de04
Compare
jimczi
approved these changes
May 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run elasticsearch-ci/2 |
hendrikmuhs
force-pushed
the
testfix-#42084
branch
from
May 21, 2019 13:43
ad2de04
to
e040c6f
Compare
run elasticsearch-ci/2 |
hendrikmuhs
force-pushed
the
testfix-#42084
branch
from
May 21, 2019 17:07
e040c6f
to
262f54d
Compare
run elasticsearch-ci/2 |
hendrikmuhs
pushed a commit
that referenced
this pull request
May 22, 2019
move latch await to doNextSearch, fixes a race condition when the executor thread is faster than the coordinator thread fixes #42084
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
move latch await to doNextSearch, fixes a race condition when the executor thread is faster than the coordinator thread fixes elastic#42084
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:ml
Machine learning
:StorageEngine/Rollup
Turn fine-grained time-based data into coarser-grained data
>test
Issues or PRs that are addressing/adding tests
v7.2.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move latch await to doNextSearch, fixes a race condition when the executor thread is faster than the coordinator thread
fixes #42084