Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .code_internal-* index pattern to kibana user #42247

Merged
merged 2 commits into from
May 22, 2019
Merged

Add .code_internal-* index pattern to kibana user #42247

merged 2 commits into from
May 22, 2019

Conversation

mw-ding
Copy link
Contributor

@mw-ding mw-ding commented May 20, 2019

Add the .code_internal-* index pattern permission to kibana user.

Addressing this issue

zfy0701
zfy0701 approved these changes May 21, 2019
@mw-ding
Copy link
Contributor Author

mw-ding commented May 21, 2019

@tvernum, can you take a look? Also, any ideas on the failing tests? what am I missing here?

@tvernum
Copy link
Contributor

tvernum commented May 22, 2019

@elasticmachine

  • run elasticsearch-ci/2
  • run elasticsearch-ci/bwc

@tvernum
Copy link
Contributor

tvernum commented May 22, 2019

BWC was failing because you were branched from a broken version. I've merged master into this branch.

@tvernum
Copy link
Contributor

tvernum commented May 22, 2019

@elasticmachine run elasticsearch-ci/1

@mw-ding mw-ding merged commit 145c3be into elastic:master May 22, 2019
@mw-ding mw-ding deleted the code-internal-queue branch May 22, 2019 15:53
@mw-ding
Copy link
Contributor Author

mw-ding commented May 22, 2019

@tvernum do we need to backport this change to 7.x or 7.2 as we do in Kibana?

@mw-ding
Copy link
Contributor Author

mw-ding commented May 22, 2019

@tvernum
I have already created 2 PRs to backport the change to 7.2 and 7.x, #42386, #42387

Please take a look

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants