-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update max_concurrent_shard_request parameter docs #42227
Update max_concurrent_shard_request parameter docs #42227
Conversation
Some of the docs were outdated as they did not mention that the limit is not per node. Also, The default value changed. Relates to elastic#31206
Pinging @elastic/es-search |
run elasticsearch-ci/bwc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, LGTM otherwise
@@ -86,11 +86,10 @@ the maximum number of concurrent searches the multi search api will execute. | |||
This default is based on the number of data nodes and the default search thread pool size. | |||
|
|||
The request parameter `max_concurrent_shard_requests` can be used to control the | |||
maximum number of concurrent shard requests the each sub search request will execute. | |||
maximum number of concurrent shard requests the each sub search request will execute per node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/maximum number of concurrent shard requests the/maximum number of concurrent shard requests that/
This parameter should be used to protect a single request from overloading a cluster | ||
(e.g., a default request will hit all indices in a cluster which could cause shard request rejections | ||
if the number of shards per node is high). This default is based on the number of | ||
data nodes in the cluster but at most `256`.In certain scenarios parallelism isn't achieved through | ||
if the number of shards per node is high). This default value is `5`.In certain scenarios searcparallelism isn't achieved through |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/In certain scenarios searcparallelism/In certain scenarios parallelism/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bla :) will fix
run elasticsearch-ci/bwc |
run elasticsearch-ci/default-distro |
Some of the docs were outdated as they did not mention that the limit is not per node. Also, The default value changed. Relates to elastic#31206
Some of the docs were outdated as they did not mention that the limit is not per node. Also, The default value changed. Relates to elastic#31206
Some of the docs were outdated as they did not mention that the limit is not per node. Also, The default value changed. Relates to #31206
Some of the docs were outdated as they did not mention that the limit is not per node. Also, The default value changed. Relates to #31206
Some of the docs were outdated as they did not mention that the limit is not per node. Also, The default value changed. Relates to #31206
Some of the docs were outdated as they did not mention that the limit is not per node. Also, The default value changed. Relates to #31206
Some of the docs were outdated as they did not mention that the limit is
not per node. Also, The default value changed.
Relates to #31206