-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Include node name when native controller cannot start process #42225
Merged
dimitris-athanasiou
merged 1 commit into
elastic:master
from
dimitris-athanasiou:include-allocated-node-in-native-controller-errors
May 22, 2019
Merged
[ML] Include node name when native controller cannot start process #42225
dimitris-athanasiou
merged 1 commit into
elastic:master
from
dimitris-athanasiou:include-allocated-node-in-native-controller-errors
May 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/ml-core |
droberts195
approved these changes
May 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dimitris-athanasiou
force-pushed
the
include-allocated-node-in-native-controller-errors
branch
from
May 20, 2019 14:33
761464a
to
7262d1f
Compare
run elasticsearch-ci/1 |
run elasticsearch-ci/bwc |
dimitris-athanasiou
force-pushed
the
include-allocated-node-in-native-controller-errors
branch
3 times, most recently
from
May 21, 2019 15:05
8ff2f30
to
821516f
Compare
This adds the node name where we fail to start a process via the native controller to facilitate debugging as otherwise it might not be known to which node the job was allocated.
run elasticsearch-ci/2 |
run elasticsearch-ci/packaging-sample |
1 similar comment
run elasticsearch-ci/packaging-sample |
dimitris-athanasiou
deleted the
include-allocated-node-in-native-controller-errors
branch
May 22, 2019 07:32
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
May 22, 2019
…lastic#42225) This adds the node name where we fail to start a process via the native controller to facilitate debugging as otherwise it might not be known to which node the job was allocated.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…lastic#42225) This adds the node name where we fail to start a process via the native controller to facilitate debugging as otherwise it might not be known to which node the job was allocated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the node name where we fail to start a process via the native
controller to facilitate debugging as otherwise it might not be known
to which node the job was allocated.