Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Include node name when native controller cannot start process #42225

Conversation

dimitris-athanasiou
Copy link
Contributor

This adds the node name where we fail to start a process via the native
controller to facilitate debugging as otherwise it might not be known
to which node the job was allocated.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimitris-athanasiou dimitris-athanasiou force-pushed the include-allocated-node-in-native-controller-errors branch from 761464a to 7262d1f Compare May 20, 2019 14:33
@dimitris-athanasiou
Copy link
Contributor Author

run elasticsearch-ci/1

@dimitris-athanasiou
Copy link
Contributor Author

run elasticsearch-ci/bwc

@dimitris-athanasiou dimitris-athanasiou force-pushed the include-allocated-node-in-native-controller-errors branch 3 times, most recently from 8ff2f30 to 821516f Compare May 21, 2019 15:05
This adds the node name where we fail to start a process via the native
controller to facilitate debugging as otherwise it might not be known
to which node the job was allocated.
@dimitris-athanasiou
Copy link
Contributor Author

run elasticsearch-ci/2

@dimitris-athanasiou
Copy link
Contributor Author

run elasticsearch-ci/packaging-sample

1 similar comment
@dimitris-athanasiou
Copy link
Contributor Author

run elasticsearch-ci/packaging-sample

@dimitris-athanasiou dimitris-athanasiou merged commit fccb7a2 into elastic:master May 22, 2019
@dimitris-athanasiou dimitris-athanasiou deleted the include-allocated-node-in-native-controller-errors branch May 22, 2019 07:32
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request May 22, 2019
…lastic#42225)

This adds the node name where we fail to start a process via the native
controller to facilitate debugging as otherwise it might not be known
to which node the job was allocated.
dimitris-athanasiou added a commit that referenced this pull request May 22, 2019
…42225) (#42338)

This adds the node name where we fail to start a process via the native
controller to facilitate debugging as otherwise it might not be known
to which node the job was allocated.
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
…lastic#42225)

This adds the node name where we fail to start a process via the native
controller to facilitate debugging as otherwise it might not be known
to which node the job was allocated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants