[ML] Fix logger declaration in ML plugins #42222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This corrects what appears to have been a copy-paste error where the logger for `MachineLearning` and `DataFrame` was wrongly set to be that of `XPackPlugin`.
dimitris-athanasiou
added
>non-issue
:ml
|
Pinging @elastic/ml-core |
| @@ -94,7 +94,7 @@ | |||
| public static final Set<String> HEADER_FILTERS = new HashSet<>( | |||
There was a problem hiding this comment.
@hendrikmuhs Also, this appears unused. Are there plans of using it?
There was a problem hiding this comment.
I think it's been refactored out into ClientHelper.SECURITY_HEADER_FILTERS (if you search for usages of that you'll see it's used in the dataframe plugin), but the old duplicated variable has not been removed in this file.
There was a problem hiding this comment.
OK, I'll remove it then in this PR.
droberts195
approved these changes
May 20, 2019
| @@ -94,7 +94,7 @@ | |||
| public static final Set<String> HEADER_FILTERS = new HashSet<>( | |||
There was a problem hiding this comment.
I think it's been refactored out into ClientHelper.SECURITY_HEADER_FILTERS (if you search for usages of that you'll see it's used in the dataframe plugin), but the old duplicated variable has not been removed in this file.
dimitris-athanasiou
added a commit
to dimitris-athanasiou/elasticsearch
that referenced
this pull request
May 21, 2019
This corrects what appears to have been a copy-paste error where the logger for `MachineLearning` and `DataFrame` was wrongly set to be that of `XPackPlugin`.
dimitris-athanasiou
added a commit
that referenced
this pull request
May 21, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
This corrects what appears to have been a copy-paste error where the logger for `MachineLearning` and `DataFrame` was wrongly set to be that of `XPackPlugin`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects what appears to have been a copy-paste error
where the logger for
MachineLearningandDataFramewas wronglyset to be that of
XPackPlugin.