SQL: Suppress geo tests failing on tr-TR locale #42200
Conversation
Due to a bug in JTS WKT parser, JTS cannot parse most of WKT shapes if the shape type is written in the lower case. For examples `point (1 2)` is causing JTS inside H2GIS to fail as a result of case-insensitive comparision. I will try to fix this issue in JTS as a follow up.
imotov
added
>test
|
Pinging @elastic/es-analytics-geo |
|
Pinging @elastic/es-search |
|
Just as a side comment: tr-TR is not the only locale with a slightly different behavior. In total I think there are 8. |
There was a problem hiding this comment.
In a similar fashion in other place in code we do this differently - https://github.com/elastic/elasticsearch/blob/master/x-pack/plugin/sql/qa/src/main/java/org/elasticsearch/xpack/sql/qa/jdbc/SqlSpecTestCase.java#L69 - but I guess is ok in this case to have a comparison with the uppercase version of point.
|
@astefan converting |
Due to a bug in JTS WKT parser, JTS cannot parse most of WKT shapes if the shape type is written in the lower case. For examples `point (1 2)` is causing JTS inside H2GIS to fail on tr-TR locale as a result of case-insensitive comparison.
Due to a bug in JTS WKT parser, JTS cannot parse most of WKT shapes if the shape type is written in the lower case. For examples `point (1 2)` is causing JTS inside H2GIS to fail on tr-TR locale as a result of case-insensitive comparison.
Due to a bug in JTS WKT parser, JTS cannot parse most of WKT shapes if
the shape type is written in the lower case. For examples
point (1 2)is causing JTS inside H2GIS to fail on tr-TR locale as a result of
case-insensitive comparison. I will try to fix this issue in JTS as a follow
up.