Remove Obsolete BwC Logic from BlobStoreRepository #42193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
original-brownbear
commented
May 17, 2019
original-brownbear
commented
- We can't restore 1.3.3 files anyway -> no point in doing the dance of computing a hash here
- Some other minor+obvious cleanups
* We can't restore 1.3.3 files anyway -> no point in doing the dance of computing a hash here * Some other minor+obvious cleanups
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed |
|
Jenkins run elasticsearch-ci/1 |
ywelsch
suggested changes
May 21, 2019
server/src/main/java/org/elasticsearch/repositories/blobstore/FileRestoreContext.java
Outdated
Show resolved
Hide resolved
|
Jenkins run elasticsearch-ci/1 |
|
thanks @ywelsch ! |
original-brownbear
added
backport pending
v7.3.0
and removed
v7.2.0
backport pending
labels
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
May 27, 2019
* Remove Obsolete BwC Logic from BlobStoreRepository * We can't restore 1.3.3 files anyway -> no point in doing the dance of computing a hash here * Some other minor+obvious cleanups
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* Remove Obsolete BwC Logic from BlobStoreRepository * We can't restore 1.3.3 files anyway -> no point in doing the dance of computing a hash here * Some other minor+obvious cleanups
original-brownbear
added a commit
that referenced
this pull request
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.