Fix test for JDBC version check #42139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The testExceptionThrownOnIncompatibleVersions test simply requires that the randomly selected version is not equal to the current version. The previous implementation of this test would sometimes randomly select CURRENT.
tvernum
added
>test
|
Pinging @elastic/es-search |
imotov
approved these changes
May 14, 2019
There was a problem hiding this comment.
I think this is an appropriate fix for this particular failure since we really want to check all previous versions not just compatible previous version. However, it doesn't address the discrepancy between behavior and comment for the randomPreviousCompatibleVersion() which says that it "returns a random version index compatible with the given version, but not the given version", when if fact it can return the given version sometimes.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
The testExceptionThrownOnIncompatibleVersions test simply requires that the randomly selected version is not equal to the current version. The previous implementation of this test would sometimes randomly select CURRENT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testExceptionThrownOnIncompatibleVersions test simply requires
that the randomly selected version is not equal to the current version.
The previous implementation of this test would sometimes randomly
select CURRENT.