Bug fix to allow access to top level params in reduce script #42096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-analytics-geo |
|
@elasticmachine run elasticsearch-ci/2 |
|
@elasticmachine run elasticsearch-ci/bwc |
rjernst
approved these changes
May 20, 2019
| @@ -72,6 +72,8 @@ | |||
| Collections.singletonMap("itemValue", 12)); | |||
| private static final Script COMBINE_SCRIPT_PARAMS = new Script(ScriptType.INLINE, MockScriptEngine.NAME, "combineScriptParams", | |||
| Collections.singletonMap("divisor", 4)); | |||
| private static final Script REDUCE_SCRIPT_AGG_PARAMS = new Script(ScriptType.INLINE, MockScriptEngine.NAME, "reduceScriptAggParams", | |||
There was a problem hiding this comment.
Can this be named without "agg" like the similar constants here?
There was a problem hiding this comment.
Good catch. Fixed.
|
@rjernst Thanks for the review! Will commit as soon as CI passes. |
|
@elasticmachine test this please |
|
@elasticmachine run elasticsearch-ci/1 |
|
@elasticmachine run elasticsearch-ci/1 |
jdconrad
added a commit
that referenced
this pull request
May 23, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters specified for use in all scripts within a metric aggregation were never merged into reduce scripts as described in this issue (#42046). This fix merges top-level parameters for a metric aggregation into reduce script parameters.