Don’t verify evictions in testFilterCacheStats #42091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>test
|
Pinging @elastic/es-distributed |
|
@dnhatn makes perfect sense to me just removing these. I wonder though for the sake of consistency, can't we just do the same fix I did for the second half of the test in 9c0a429 at the beginning of this test as well and simply force merge to avoid the background merges? (the question is more for my education in case the answer is no, this fix is just fine with me :) as well) |
|
@original-brownbear I considered your option first then I thought it's more interesting if we let merges happen. I am fine with either way. |
|
@dnhatn let's keep yours :) no reason to forego the coverage of what happens with ongoing merges then. |
|
Thanks @original-brownbear |
dnhatn
added a commit
that referenced
this pull request
May 15, 2019
If a background merge and refresh happens after a search but before a stats query, then evictions will be non-zero. Closes #32506
dnhatn
added a commit
that referenced
this pull request
May 15, 2019
If a background merge and refresh happens after a search but before a stats query, then evictions will be non-zero. Closes #32506
dnhatn
added a commit
that referenced
this pull request
May 16, 2019
If a background merge and refresh happens after a search but before a stats query, then evictions will be non-zero. Closes #32506
dnhatn
added a commit
that referenced
this pull request
May 16, 2019
If a background merge and refresh happens after a search but before a stats query, then evictions will be non-zero. Closes #32506
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
If a background merge and refresh happens after a search but before a stats query, then evictions will be non-zero. Closes elastic#32506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a background merge and refresh happens after a search (line 1032) but before a stats query (line 1034), then
evictionswill be non-zero. I removed these assertions since they are quite brittle.Closes #32506