Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random failure in SearchRequestTests#testRandomVersionSerialization #42069

Merged
merged 1 commit into from
May 20, 2019

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented May 10, 2019

This commit fixes a test bug that ends up comparing the result of two consecutive calls to System.currentTimeMillis that can be different
on slow CIs.

Closes #42064

This commit fixes a test bug that ends up comparing the result of two consecutive calls to System.currentTimeMillis that can be different
on slow CIs.

Closes elastic#42064
@jimczi jimczi added >non-issue :Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI labels May 10, 2019
@jimczi jimczi requested a review from javanna May 10, 2019 10:54
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch thanks @jimczi

@jimczi
Copy link
Contributor Author

jimczi commented May 20, 2019

Jenkins run elasticsearch-ci/docbldesx

@jimczi jimczi merged commit f7a4f92 into elastic:master May 20, 2019
@jimczi jimczi deleted the bug/search_request_test branch May 20, 2019 08:02
jimczi added a commit that referenced this pull request May 20, 2019
…on (#42069)

This commit fixes a test bug that ends up comparing the result of two consecutive calls to System.currentTimeMillis that can be different
on slow CIs.

Closes #42064
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
…on (elastic#42069)

This commit fixes a test bug that ends up comparing the result of two consecutive calls to System.currentTimeMillis that can be different
on slow CIs.

Closes elastic#42064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Search/Search Search-related issues that do not fall into other categories >test-failure Triaged test failures from CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchRequestTests testRandomVersionSerialization failure
3 participants