Fix Race in Closing IndicesService.CacheCleaner #42016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When close becomes true while the management pool is shut down, we run into an unhandled `EsRejectedExecutionException` that fails tests * Found this while trying to reproduce elastic#32506 * Running the IndexStatsIT in a loop is a way of reproducing this
original-brownbear
added
>non-issue
:Distributed Indexing/CRUD
|
Pinging @elastic/es-distributed |
dnhatn
approved these changes
May 9, 2019
|
thanks @dnhatn ! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
May 10, 2019
* When close becomes true while the management pool is shut down, we run into an unhandled `EsRejectedExecutionException` that fails tests * Found this while trying to reproduce elastic#32506 * Running the IndexStatsIT in a loop is a way of reproducing this
original-brownbear
added a commit
that referenced
this pull request
May 10, 2019
* When close becomes true while the management pool is shut down, we run into an unhandled `EsRejectedExecutionException` that fails tests * Found this while trying to reproduce #32506 * Running the IndexStatsIT in a loop is a way of reproducing this
ywelsch
reviewed
May 10, 2019
| @@ -1219,7 +1220,13 @@ public void run() { | |||
| } | |||
| // Reschedule itself to run again if not closed | |||
| if (closed.get() == false) { | |||
| threadPool.schedule(this, interval, ThreadPool.Names.SAME); | |||
| try { | |||
| threadPool.schedule(this, interval, ThreadPool.Names.SAME); | |||
There was a problem hiding this comment.
easier to use scheduleUnlessShuttingDown?
There was a problem hiding this comment.
Oh sorry! Didn't know about that method, will open cleanup PR in a sec.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
May 10, 2019
* Follow up to elastic#42016
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* When close becomes true while the management pool is shut down, we run into an unhandled `EsRejectedExecutionException` that fails tests * Found this while trying to reproduce elastic#32506 * Running the IndexStatsIT in a loop is a way of reproducing this
original-brownbear
added a commit
that referenced
this pull request
Jun 24, 2019
* Follow up to #42016
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jun 24, 2019
original-brownbear
added a commit
that referenced
this pull request
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runnablehere is being shut down, we run into an unhandeledEsRejectedExecutionExceptionthat fails testsIndexStatsITin a loop is a way of reproducing this