Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Harmful Exists Check from BlobStoreFormat #41898

Merged
merged 1 commit into from
May 7, 2019

Commits on May 7, 2019

  1. Remove Harmful Exists Check from BlobStoreFormat

    * First off, this exists check is somewhat pointless in that it checks
    for the existence of a blob that contains a UUID in its name so we don't
    expect collisions here ever. Just checking for no name collision is
    completely sufficient.
    * More importantly though, this check introduces an issue on S3 because
    we will run it against a non existing snap-{uuid}.dat blob!
      * This leads to the fact that subsequent reads of this blob after it
    was written can still return a 404 because AWS S3 only guarantees first
    read after write consistency. If a read of a key is made before a write
    is made this guarantee goes out the window. (see
    https://docs.aws.amazon.com/AmazonS3/latest/dev/Introduction.html#ConsistencyModel
    for more)
    * Closes elastic#41882
    original-brownbear committed May 7, 2019
    Configuration menu
    Copy the full SHA
    6af66fc View commit details
    Browse the repository at this point in the history