Add tasks to build Docker build context artifacts #41819
Conversation
jasontedor
added
:Delivery/Build
|
Pinging @elastic/es-core-infra |
This commit adds some tasks to generate dedicated Docker build context artifacts.
jasontedor
force-pushed
the
docker-build-context
branch
from
2ffbab4 to
210335e
Compare
| @@ -0,0 +1,3 @@ | |||
| apply plugin: 'base' | |||
|
|
|||
| assemble.dependsOn ":distribution:docker:buildDockerBuildContext" | |||
There was a problem hiding this comment.
Why are we adding new projects for thees ?
I'm not sure what value these bring.
There was a problem hiding this comment.
@atorok It's the same structure as all of our other projects in distribution that produce artifacts, the only difference being there are explicit Gradle build files here instead of being wired up through Gradle magic in a root Gradle build file.
There was a problem hiding this comment.
thanks for the explanation!
There was a problem hiding this comment.
The reason we have individual projects is so each of those projects has the one artifact as the default artifact. Here we aren't actually consuming this build context anywhere in tests that need to depend on one or the other right? In fact, we can likely get rid of the layers we have distribution now that we don't use dependency substitution anymore for them.
The thing that gives me pause most is having a hard dependency back to the :distribution:docker project on 2 tasks there. I don't see any benefit to running :distribution:docker:docker-build-context:assemble instead of :distribution:docker:buildDockerBuildContext
There was a problem hiding this comment.
@rjernst I pushed a commit that I think addresses your concerns. The back dependency is gone.
This commit adds some tasks to generate dedicated Docker build context artifacts.
This commit adds some tasks to generate dedicated Docker build context artifacts.
This commit adds some tasks to generate dedicated Docker build context artifacts.
* elastic/master: (414 commits) Add tasks to build Docker build context artifacts (elastic#41819) Replace more uses of immutable map builder (elastic#41823) Force selection of calendar or fixed intervals in date histo agg (elastic#33727) Switch run task to use real distro (elastic#41590) Clarify that path_match also considers object fields. (elastic#41658) [DOCS] remove 'es.scripting.update.ctx_in_params' system property for 7.0 (elastic#41643) Clarify _doc is a permanent part of certain document APIs. (elastic#41727) Remove the jdk directory to save space on bwc tests (elastic#41743) Fix full text queries test that start with now (elastic#41854) Remove `nonApplicationWrite` from `SSLDriver` (elastic#41829) SQL: [Docs] Add example for custom bucketing with CASE (elastic#41787) Cleanup Bulk Delete Exception Logging (elastic#41693) [DOCS] Rewrite `term` query docs for new format (elastic#41498) Mute PermissionsIT#testWhen[...]ByILMPolicy (elastic#41858) ReadOnlyEngine assertion fix (elastic#41842) [ML] addresses preview bug, and adds check to PUT (elastic#41803) Fix javadoc in WrapperQueryBuilder Testsclusters use seprate configurations per version (elastic#41504) Skip explain fetch sub phase when request holds only suggestions (elastic#41739) remove unused import ...
This commit adds some tasks to generate dedicated Docker build context artifacts.
This commit adds some tasks to generate dedicated Docker build context artifacts.
Closes #41454