Fix BulkProcessorRetryIT #41700
Merged
Fix BulkProcessorRetryIT #41700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
original-brownbear
commented
Apr 30, 2019
original-brownbear
commented
- Now that we process the bulk requests themselves on the WRITE threadpool, they can run out of retries too like the item requests even when backoff is active
- Fixes [CI] Test Failure in org.elasticsearch.client.BulkProcessorRetryIT#testBulkRejectionLoadWithBackoff #41324 by using the same logic that checks failed item requests for their retry status for the top level bulk requests as well
* Now that we process the bulk requests themselves on the WRITE threadpool, they can run out of retries too like the item requests even when backoff is active * Fixes elastic#41324 by using the same logic that checks failed item requests for their retry status for the top level bulk requests as well
original-brownbear
added
>test
|
Pinging @elastic/es-distributed |
|
Jenkins run elasticsearch-ci/2 (build was aborted by Jenkins restart) |
|
thanks @jaymode ! |
akhil10x5
pushed a commit
to akhil10x5/elasticsearch
that referenced
this pull request
May 2, 2019
* Now that we process the bulk requests themselves on the WRITE threadpool, they can run out of retries too like the item requests even when backoff is active * Fixes elastic#41324 by using the same logic that checks failed item requests for their retry status for the top level bulk requests as well
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* Now that we process the bulk requests themselves on the WRITE threadpool, they can run out of retries too like the item requests even when backoff is active * Fixes elastic#41324 by using the same logic that checks failed item requests for their retry status for the top level bulk requests as well
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
May 28, 2019
* Now that we process the bulk requests themselves on the WRITE threadpool, they can run out of retries too like the item requests even when backoff is active * Fixes elastic#41324 by using the same logic that checks failed item requests for their retry status for the top level bulk requests as well
original-brownbear
added a commit
that referenced
this pull request
May 28, 2019
* Now that we process the bulk requests themselves on the WRITE threadpool, they can run out of retries too like the item requests even when backoff is active * Fixes #41324 by using the same logic that checks failed item requests for their retry status for the top level bulk requests as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.