Remove usage of max_local_storage_nodes in test infrastructure #41652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra |
DaveCTurner
reviewed
May 1, 2019
There was a problem hiding this comment.
I left a couple of minor comments, but this looks good. CI failed without giving any useful feedback:
org.elasticsearch.gradle.testclusters.TestClustersPluginIT > testMultiProject FAILED
org.gradle.testkit.runner.UnexpectedBuildFailure at TestClustersPluginIT.java:88
|
|
||
| ensureGreen(); | ||
|
|
||
| // index is gone. | ||
| assertFalse(indexExists(indexName)); | ||
| } | ||
|
|
||
| private void executeRepurposeCommandForOrdinal(Settings settings, String indexUUID, int ordinal, | ||
| private void executeRepurposeCommandForOrdinal(Settings settings, String indexUUID, |
There was a problem hiding this comment.
This method name mensions ordinal but ordinal is no longer an argument.
| updatedSettings.put(Environment.PATH_DATA_SETTING.getKey(), baseDir.resolve(name)); | ||
| } | ||
|
|
||
| updatedSettings.put(Environment.PATH_SHARED_DATA_SETTING.getKey(), baseDir.resolve(name + "-shared")); |
There was a problem hiding this comment.
Do we still need this? It seems strange that it's set in every integration test when it's so rarely used in production.
There was a problem hiding this comment.
yes, it's used by ESIntegTestCase which 30% of the time uses custom data path (see ESIntegTestCase#indexSettings())
|
The above test failures are not reproducible after merging in latest master. |
|
@elasticmachine run elasticsearch-ci/1 |
|
@elasticmachine run elasticsearch-ci/1 |
DaveCTurner
approved these changes
May 14, 2019
…torage-nodes-usage
…torage-nodes-usage
|
@elasticmachine run elasticsearch-ci/1 |
ywelsch
added a commit
that referenced
this pull request
May 22, 2019
Moves the test infrastructure away from using node.max_local_storage_nodes, allowing us in a follow-up PR to deprecate this setting in 7.x and to remove it in 8.0. This also changes the behavior of InternalTestCluster so that starting up nodes will not automatically reuse data folders of previously stopped nodes. If this behavior is desired, it needs to be explicitly done by passing the data path from the stopped node to the new node that is started.
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
…ic#41652) Moves the test infrastructure away from using node.max_local_storage_nodes, allowing us in a follow-up PR to deprecate this setting in 7.x and to remove it in 8.0. This also changes the behavior of InternalTestCluster so that starting up nodes will not automatically reuse data folders of previously stopped nodes. If this behavior is desired, it needs to be explicitly done by passing the data path from the stopped node to the new node that is started.
ywelsch
added a commit
that referenced
this pull request
Dec 17, 2019
With node ordinals gone, there's no longer a need for such a complicated full cluster restart procedure (as we can now uniquely associate nodes to data folders). Follow-up to #41652
ywelsch
added a commit
that referenced
this pull request
Dec 17, 2019
With node ordinals gone, there's no longer a need for such a complicated full cluster restart procedure (as we can now uniquely associate nodes to data folders). Follow-up to #41652
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
With node ordinals gone, there's no longer a need for such a complicated full cluster restart procedure (as we can now uniquely associate nodes to data folders). Follow-up to elastic#41652
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the test infrastructure away from using
node.max_local_storage_nodes, allowing us in a follow-up PR to deprecate this setting in 7.x and to remove it in 8.0.This also changes the behavior of InternalTestCluster so that starting up nodes will not automatically reuse data folders of previously stopped nodes. If this behavior is desired, it needs to be explicitly done by passing the data path from the stopped node to the new node that is started.