Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move primary term from replicas proxy to repl op #41119

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Move primary term from replicas proxy to repl op #41119

merged 1 commit into from
Apr 11, 2019

Conversation

DaveCTurner
Copy link
Contributor

A small refactoring that removes the primaryTerm field from ReplicasProxy and
instead passes it directly in to the methods that need it.

@DaveCTurner
Move primary term from replicas proxy to repl op
c4690e4 
A small refactoring that removes the primaryTerm field from ReplicasProxy and
instead passes it directly in to the methods that need it.
@DaveCTurner DaveCTurner added >non-issue :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v8.0.0 v7.2.0 labels Apr 11, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

dnhatn
dnhatn approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just curious about the benefits of this refactoring?

@DaveCTurner
Copy link
Contributor Author

Thanks @dnhatn. This is another step towards the separation of concerns described in #40706; at least, it means we don't need to add yet more factories to perform that separation.

@DaveCTurner DaveCTurner merged commit b41e3fc into elastic:master Apr 11, 2019
@DaveCTurner DaveCTurner deleted the 2019-04-11-remove-primary-term-from-replicas-proxy branch April 11, 2019 19:26
DaveCTurner added a commit that referenced this pull request Apr 11, 2019
@DaveCTurner
Move primary term from replicas proxy to repl op (#41119)
b522de9 
A small refactoring that removes the primaryTerm field from ReplicasProxy and
instead passes it directly in to the methods that need it. Relates #40706.
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
@DaveCTurner
Move primary term from replicas proxy to repl op (elastic#41119)
59ffa92 
A small refactoring that removes the primaryTerm field from ReplicasProxy and
instead passes it directly in to the methods that need it. Relates elastic#40706.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnhatn dnhatn dnhatn approved these changes

@henningandersen henningandersen Awaiting requested review from henningandersen

Assignees
No one assigned
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >non-issue v7.2.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DaveCTurner @elasticmachine @dnhatn @jakelandis