[ML] fixing test related to #40963 #41074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>test
|
Pinging @elastic/ml-core |
davidkyle
reviewed
Apr 10, 2019
| @@ -131,7 +130,6 @@ public void testGetPersistedStatsWithoutTask() throws Exception { | |||
| for (Map<String, Object> transformStats : transformsStats) { | |||
| Map<String, Object> stat = (Map<String, Object>)transformStats.get("stats"); | |||
| assertThat(((Integer)stat.get("documents_processed")), greaterThan(0)); | |||
| assertThat(((Integer)stat.get("search_time_in_ms")), greaterThan(0)); | |||
There was a problem hiding this comment.
@davidkyle I could, but that does not add anything :(. A 0 value is also the default value for when there aren't stats recorded
There was a problem hiding this comment.
it proves the field is present... but that should be covered in other tests
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Apr 11, 2019
benwtrent
added a commit
that referenced
this pull request
Apr 11, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the possible zero value check of
search_time_in_ms. I have seen this before where the search time is actually recorded as zero. This is OK for this test as we really only care about there being valid statistics. The remain checks are enough to achieve this.closes #40963