Upgrade to lucene 8.1.0-snapshot-e460356abe #40952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimczi
added
>upgrade
:Distributed Indexing/Engine
|
Pinging @elastic/es-distributed |
|
A small note for reviewer, I had to revert #33196 because the |
romseygeek
approved these changes
Apr 15, 2019
| } else if (query instanceof FunctionScoreQuery) { | ||
| return Collections.singletonList(((FunctionScoreQuery) query).getSubQuery()); | ||
| } else if (query instanceof ESToParentBlockJoinQuery) { | ||
| return Collections.singletonList(((ESToParentBlockJoinQuery) query).getChildQuery()); |
There was a problem hiding this comment.
Do we not need these any more?
There was a problem hiding this comment.
The unified highlighter uses a QueryVisitor to extract the terms now so I added a visit implementation for these queries since this code is only called to extract phrase and span queries:
https://github.com/elastic/elasticsearch/pull/40952/files#diff-4d092acdc70f570b9d18594dcffb95a6R80
https://github.com/elastic/elasticsearch/pull/40952/files#diff-80c91092d36bb5d49bdd3ef462f75e40R201
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
May 9, 2019
jimczi
added a commit
that referenced
this pull request
May 23, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit upgrades the master branch to the latest snapshot of lucene 8.1.0.