Improve GCS docs for using keystore #40605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tweaks the wording on using the keystore to store GCS credentials to note it requires a different key type/command. closes elastic#39993
rjernst
added
>docs
|
Pinging @elastic/es-distributed |
jrodewig
approved these changes
Mar 29, 2019
| @@ -88,8 +88,9 @@ A JSON service account file looks like this: | |||
| ---- | |||
| // NOTCONSOLE | |||
|
|
|||
| To provide this file to the plugin, it must be stored in the {ref}/secure-settings.html[Elasticsearch keystore]. You must add a setting name of the form `gcs.client.NAME.credentials_file`, where `NAME` | |||
| is the name of the client configuration for the repository. The implicit client | |||
| To provide this file to the plugin, it must be stored in the {ref}/secure-settings.html[Elasticsearch keystore]. You must | |||
There was a problem hiding this comment.
Not blocking, but we can use the {es} attribute instead of Elasticsearch here.
There was a problem hiding this comment.
I'm not sure what the {es} attribute is. Can you suggest a specific change to the text?
There was a problem hiding this comment.
{es} here will expand to Elasticsearch.
Suggested change
| To provide this file to the plugin, it must be stored in the {ref}/secure-settings.html[Elasticsearch keystore]. You must | |
| To provide this file to the plugin, it must be stored in the {ref}/secure-settings.html[{es} keystore]. You must |
There was a problem hiding this comment.
I'm going to skip this for now, as there are other uses of "Elasticsearch" in this file and I don't want to create an inconsistency.
rjernst
added a commit
that referenced
this pull request
Apr 3, 2019
This commit tweaks the wording on using the keystore to store GCS credentials to note it requires a different key type/command. closes #39993
rjernst
added a commit
that referenced
this pull request
Apr 3, 2019
This commit tweaks the wording on using the keystore to store GCS credentials to note it requires a different key type/command. closes #39993
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 3, 2019
…leniency * elastic/master: SQL: Fix deserialisation issue of TimeProcessor (elastic#40776) Improve GCS docs for using keystore (elastic#40605) Add Restore Operation to SnapshotResiliencyTests (elastic#40634) Small refactorings to analysis components (elastic#40745) SQL: Fix display size for DATE/DATETIME (elastic#40669) add HLRC protocol tests for transform state and stats (elastic#40766) Inline TransportReplAction#registerRequestHandlers (elastic#40762) remove experimental label from search_as_you_type documentation (elastic#40744) Remove some abstractions from `TransportReplicationAction` (elastic#40706) Upgrade to latest build scan plugin (elastic#40702) Use default memory lock setting in testing (elastic#40730) Add Bulk Delete Api to BlobStore (elastic#40322) Remove yaml skips older than 7.0 (elastic#40183) Docs: Move id in the java-api (elastic#40748)
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
This commit tweaks the wording on using the keystore to store GCS credentials to note it requires a different key type/command. closes elastic#39993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tweaks the wording on using the keystore to store GCS
credentials to note it requires a different key type/command.
closes #39993