Always delegate TransportIndexAction and TransportDeleteAction to bulk action #40424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>non-issue
:Distributed Indexing/CRUD
|
Pinging @elastic/es-distributed |
bleskes
approved these changes
Mar 26, 2019
| @@ -166,6 +166,7 @@ protected void registerRequestHandlers(String actionName, TransportService trans | |||
|
|
|||
| @Override | |||
| protected void doExecute(Task task, Request request, ActionListener<Response> listener) { | |||
| assert request.shardId() != null : "request shardId must be set"; | |||
There was a problem hiding this comment.
Interesting - did you run into a situation when this wasn't the case?
There was a problem hiding this comment.
no, but this work got triggered by looking at open Github issues, in particular #20279 . In particular I noticed that the desired property to have a complete ShardId when replication requests get to the reroute phase already holds today.
This PR does not close that issue out (needs further investigation on what exactly needs to be done), but addresses the first point on it.
|
@elasticmachine run elasticsearch-ci/packaging-sample |
ywelsch
added a commit
that referenced
this pull request
Mar 27, 2019
The implementation of TransportIndexAction and TransportDeleteAction as TransportReplicationAction existed for interoperability with older 5.x nodes, as these older nodes coordinated single index / deletes as replication requests. This BWC layer is no longer needed in 7.x, where these single actions are now mapped to bulk requests. Completely removing the deprecated transport actions is not possible yet if we want to keep BWC with a 6.x transport client. The best way here is to wait for the transport client to go away and then just remove the actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
TransportIndexActionandTransportDeleteActionasTransportReplicationActionexisted for interoperability with older 5.x nodes, as these older nodes coordinated single index / deletes as replication requests. This BWC layer is no longer needed in 7.x, where these single actions are now mapped to bulk requests. Completely removing the deprecated transport actions is not possible yet if we want to keep BWC with a 6.x transport client. The best way here is to wait for the transport client to go away and then just remove the actions.