-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alpha build error message when generate version object from version string #40406
Conversation
Hi @mushao999, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile? |
8901541
to
a6a78f4
Compare
Pinging @elastic/es-core-infra |
@javanna Cloud you please review this PR? This is my first OS contribution, though it is really a small one. |
@elasticmachine test this please |
@tvernum @elasticmachine I got the following error while build elasticsearch-ci/1
Cloud you please help me with this ? |
@tvernum hi, this PR did not pass the elasticsearch/cli check yesterday, the error message showed it had something to do with the network of test machine. So I made a force push in order to invoke the recheck which didn't work. Could you please help me to start the check again. Thank you very much. |
@elasticmachine test this please |
@tvernum @javanna @colings86 @elasticmachine Why is a small pull request so difficult to be accepted? |
@mushao999 I apologize for the long delay. Your change looks fine. Getting CI to pass is sometimes difficult, and even for innocuous changes we require passing that before merging. It looks like your PR is a month behind |
@rjernst Hi, thank you for your help. I have updated the master branch in my repository. Please help me to pass the checks. |
@elasticmachine test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @mushao999!
Class org.elasticsearch.Version provides the method
public static Version fromString(String version){...}
to generate version object from version string . In this method, alpha build requires a build number below 25. So in assertionat line 328, what really exceped is alpha build not beta build.