Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alpha build error message when generate version object from version string #40406

Merged
merged 1 commit into from
May 22, 2019

Conversation

mushao999
Copy link
Contributor

Class org.elasticsearch.Version provides the method public static Version fromString(String version){...} to generate version object from version string . In this method, alpha build requires a build number below 25. So in assertion

assert build < 25 : "expected a beta build but " + build + " >= 25";

at line 328, what really exceped is alpha build not beta build.

@elasticcla
Copy link

Hi @mushao999, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@mushao999 mushao999 force-pushed the master branch 2 times, most recently from 8901541 to a6a78f4 Compare March 25, 2019 12:53
@colings86 colings86 added the :Core/Infra/Core Core issues without another label label Mar 25, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@mushao999
Copy link
Contributor Author

@javanna Cloud you please review this PR? This is my first OS contribution, though it is really a small one.

@tvernum
Copy link
Contributor

tvernum commented Mar 28, 2019

@elasticmachine test this please

@mushao999
Copy link
Contributor Author

mushao999 commented Mar 28, 2019

@tvernum @elasticmachine I got the following error while build elasticsearch-ci/1

==> krb5kdc: Waiting for machine to boot. This may take a few minutes...
    krb5kdc: SSH address: 127.0.0.1:2222
    krb5kdc: SSH username: vagrant
    krb5kdc: SSH auth method: private key
Timed out while waiting for the machine to boot. This means that
Vagrant was unable to communicate with the guest machine within

the configured ("config.vm.boot_timeout" value) time period.
> Task :plugins:repository-hdfs:krb5kdcFixture FAILED

Cloud you please help me with this ?

@mushao999
Copy link
Contributor Author

mushao999 commented Mar 28, 2019

@tvernum hi, this PR did not pass the elasticsearch/cli check yesterday, the error message showed it had something to do with the network of test machine. So I made a force push in order to invoke the recheck which didn't work. Could you please help me to start the check again. Thank you very much.

@mushao999
Copy link
Contributor Author

@tvernum
Copy link
Contributor

tvernum commented Apr 3, 2019

@elasticmachine test this please

@mushao999
Copy link
Contributor Author

@tvernum @javanna @colings86 @elasticmachine Why is a small pull request so difficult to be accepted?

@rjernst
Copy link
Member

rjernst commented May 19, 2019

@mushao999 I apologize for the long delay. Your change looks fine. Getting CI to pass is sometimes difficult, and even for innocuous changes we require passing that before merging.

It looks like your PR is a month behind master. Can you update that please? There have been many CI stabilization improvements in the last month. I would then be happy to quickly drive this through CI to get it merged. Also, I recommend not opening PRs based on your master branch. If you had a branch off of master, I would have tried syncing it up myself, but I do not want to touch your copy of master.

@mushao999
Copy link
Contributor Author

@rjernst Hi, thank you for your help. I have updated the master branch in my repository. Please help me to pass the checks.

@rjernst
Copy link
Member

rjernst commented May 22, 2019

@elasticmachine test this please

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @mushao999!

@rjernst rjernst merged commit d5888b2 into elastic:master May 22, 2019
rjernst pushed a commit that referenced this pull request May 22, 2019
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
@jpountz jpountz added the >bug label Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants