Optimise rejection of out-of-range long values
#40325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today if you try and insert a very large number like `1e9999999` into a long field we first construct this number as a `BigDecimal`, convert this to a `BigInteger` and then reject it because it is out of range. Unfortunately making such a large `BigInteger` is rather expensive. We can avoid this expense by performing a (weaker) range check on the `BigDecimal` representation of incoming `long`s too. Relates elastic#26137 Closes elastic#40323
DaveCTurner
added
>bug
:Search Foundations/Mapping
|
Pinging @elastic/es-search |
jpountz
approved these changes
Mar 21, 2019
| @@ -27,19 +28,26 @@ | |||
|
|
|||
| public class NumbersTests extends ESTestCase { | |||
|
|
|||
| @Timeout(millis = 10000) | |||
| @@ -367,17 +368,20 @@ public void testEmptyName() throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| @Timeout(millis = 30000) | |||
|
I was unsure about whether to include these timeouts. The tests complete in milliseconds today with the fix, but I'm nervous about short timeouts adding to CI flakiness. Without the fix or the timeout these tests take a very long time to fail which I think isn't great either. I don't feel strongly, however, and will take them out if you think it better. |
DaveCTurner
added a commit
that referenced
this pull request
Mar 28, 2019
Today if you try and insert a very large number like `1e9999999` into a long field we first construct this number as a `BigDecimal`, convert this to a `BigInteger` and then reject it because it is out of range. Unfortunately making such a large `BigInteger` is rather expensive. We can avoid this expense by performing a (weaker) range check on the `BigDecimal` representation of incoming `long`s too. Relates #26137 Closes #40323
DaveCTurner
added a commit
that referenced
this pull request
Mar 28, 2019
Today if you try and insert a very large number like `1e9999999` into a long field we first construct this number as a `BigDecimal`, convert this to a `BigInteger` and then reject it because it is out of range. Unfortunately making such a large `BigInteger` is rather expensive. We can avoid this expense by performing a (weaker) range check on the `BigDecimal` representation of incoming `long`s too. Relates #26137 Closes #40323
jasontedor
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Mar 28, 2019
* master: (25 commits) [DOCS] Correct keystore commands for Email and Jira actions in Watcher (elastic#40417) [DOCS] Document common settings for snapshot repository plugins (elastic#40475) Remove with(out)-system-key tests (elastic#40547) Geo Point parse error fix (elastic#40447) Handle null retention leases in WaitForNoFollowersStep (elastic#40477) [DOCS] Adds anchors for ruby client (elastic#39867) Mute DataFrameAuditorIT#testAuditorWritesAudits Disable integTest when Docker is not available (elastic#40585) Add randomScore function in script_score query (elastic#40186) Test fixtures krb5 (elastic#40297) Correct ILM metadata minimum compatibility version (elastic#40569) SQL: Centralize SQL test dependencies version handling (elastic#40551) Mute testTracerLog Mute testHttpInput Include functions' aliases in the list of functions (elastic#40584) Optimise rejection of out-of-range `long` values (elastic#40325) Add docs for cluster.remote.*.proxy setting (elastic#40281) Migrate systemd packaging tests from bats to java (elastic#39954) Move top-level pipeline aggs out of QuerySearchResult (elastic#40319) Use openjdk 12 in packer cache script (elastic#40498) ...
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 29, 2019
* elastic/7.0: (50 commits) Fix more broken links in plugins docs Fix archives links in plugins docs Disable integTest when Docker is not available (elastic#40585) Add docs for bundled jdk (elastic#40487) [DOCS] Correct keystore commands for Email and Jira actions in Watcher (elastic#40417) (elastic#40613) Add usage indicators for the bundled JDK (elastic#40616) Add ability to mute and mute flaky fixture (elastic#40630) Test fixtures krb5 (elastic#40297) Update docs for the DFR similarity (elastic#40579) Update ingest jdocs that a null return value will drop the current document. (elastic#40359) [DOCS] Document common settings for snapshot repository plugins (elastic#40475) (elastic#40607) [DOCS] Fixes formatting in breaking changes Handle null retention leases in WaitForNoFollowersStep (elastic#40477) Correct ILM metadata minimum compatibility version (elastic#40569) Mute SpecificMasterNodesIT.testElectOnlyBetweenMasterNodes() Mute testHttpInput Include functions' aliases in the list of functions (elastic#40584) Optimise rejection of out-of-range `long` values (elastic#40325) Add docs for cluster.remote.*.proxy setting (elastic#40281) Mute WatchAckTests.testAckAllActions ...
DaveCTurner
added a commit
that referenced
this pull request
Apr 5, 2019
Today if you try and insert a very large number like `1e9999999` into a long field we first construct this number as a `BigDecimal`, convert this to a `BigInteger` and then reject it because it is out of range. Unfortunately making such a large `BigInteger` is rather expensive. We can avoid this expense by performing a (weaker) range check on the `BigDecimal` representation of incoming `long`s too. Relates #26137 Closes #40323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today if you try and insert a very large number like
1e9999999into a longfield we first construct this number as a
BigDecimal, convert this to aBigIntegerand then reject it because it is out of range. Unfortunatelymaking such a large
BigIntegeris rather expensive.We can avoid this expense by performing a (weaker) range check on the
BigDecimalrepresentation of incominglongs too.Relates #26137
Closes #40323