Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for .watches that wasn't upgraded properly #39609

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

gwbrown
Copy link
Contributor

@gwbrown gwbrown commented Mar 3, 2019

If the .watches index was created in 5.6 and is still a concrete
index, rather than an alias for .watches-6, that means that it was not
properly upgraded with the Migration Upgrade API before upgrading to
Elasticsearch 6.x. In this case, calling the Migration Upgrade API is
needed to resolve the problem with the .watches index, as a simple
reindex will not.

This isn't going to be a common case, as Watcher will not run properly
in this situation, but we should handle it and notify the user of the
correct action, just in case.

/cc @joshdover as this relates to elastic/kibana#32251

If the `.watches` index was created in 5.6 and is still a concrete
index, rather than an alias for `.watches-6`, that means that it was not
properly upgraded with the Migration Upgrade API before upgrading to
Elasticsearch 6.x. In this case, calling the Migration Upgrade API will
resolve the problem with the `.watches` index.

This isn't going to be a common case, as Watcher will not run properly
in this situation, but we should handle it and notify the user of the
correct action, just in case.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwbrown gwbrown merged commit 63eb0bb into elastic:6.7 Mar 4, 2019
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Mar 6, 2019
* 6.7: (39 commits)
  Remove beta label from CCR (elastic#39722)
  Rename retention lease setting (elastic#39719)
  Add Docker build type (elastic#39378)
  Use any index specified by .watches for Watcher (elastic#39541) (elastic#39706)
  Add documentation on remote recovery (elastic#39483)
  fix typo in synonym graph filter docs
  Removed incorrect ML YAML tests (elastic#39400)
  Improved Terms Aggregation documentation (elastic#38892)
  Fix Fuzziness#asDistance(String) (elastic#39643)
  Revert "unmute EvilLoggerTests#testDeprecatedSettings (elastic#38743)"
  Mute TokenAuthIntegTests.testExpiredTokensDeletedAfterExpiration (elastic#39690)
  Fix security index auto-create and state recovery race (elastic#39582)
  [DOCS] Sorts security APIs
  Check for .watches that wasn't upgraded properly (elastic#39609)
  Assert recovery done in testDoNotWaitForPendingSeqNo (elastic#39595)
  [DOCS] Updates API in Watcher transform context (elastic#39540)
  Fixing the custom object serialization bug in diffable utils. (elastic#39544)
  mute test
  SQL: Don't allow inexact fields for MIN/MAX (elastic#39563)
  Update release notes for 6.7.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants