-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use non-ILM template setting up watch history template & ILM disabled #39325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ILM is disabled and Watcher is setting up the templates and policies for the watch history indices, it will now use a template that does not have the `index.lifecycle.name` setting, so that indices are not created with the setting. This also adds tests for the behavior, and changes the cluster state used in these tests to be real instead of mocked. Resolves elastic#38805
Pinging @elastic/es-core-features |
@elasticmachine run elasticsearch-ci/1 |
gwbrown
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 26, 2019
…elastic#39325) When ILM is disabled and Watcher is setting up the templates and policies for the watch history indices, it will now use a template that does not have the `index.lifecycle.name` setting, so that indices are not created with the setting. This also adds tests for the behavior, and changes the cluster state used in these tests to be real instead of mocked. Resolves elastic#38805
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 26, 2019
…elastic#39325) When ILM is disabled and Watcher is setting up the templates and policies for the watch history indices, it will now use a template that does not have the `index.lifecycle.name` setting, so that indices are not created with the setting. This also adds tests for the behavior, and changes the cluster state used in these tests to be real instead of mocked. Resolves elastic#38805
This was referenced Feb 26, 2019
dakrone
added a commit
that referenced
this pull request
Feb 27, 2019
…#39420) Backport of #39325 When ILM is disabled and Watcher is setting up the templates and policies for the watch history indices, it will now use a template that does not have the `index.lifecycle.name` setting, so that indices are not created with the setting. This also adds tests for the behavior, and changes the cluster state used in these tests to be real instead of mocked. Resolves #38805
dakrone
added a commit
that referenced
this pull request
Feb 27, 2019
…#39421) Backport of #39325 When ILM is disabled and Watcher is setting up the templates and policies for the watch history indices, it will now use a template that does not have the `index.lifecycle.name` setting, so that indices are not created with the setting. This also adds tests for the behavior, and changes the cluster state used in these tests to be real instead of mocked. Resolves #38805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ILM is disabled and Watcher is setting up the templates and policies for
the watch history indices, it will now use a template that does not have the
index.lifecycle.name
setting, so that indices are not created with thesetting.
This also adds tests for the behavior, and changes the cluster state used in
these tests to be real instead of mocked.
Resolves #38805