Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Unset machine learning upgrade mode #39149

Merged
merged 3 commits into from
Feb 20, 2019
Merged

[DOCS] Unset machine learning upgrade mode #39149

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31fd91f
[DOCS] Unset ML upgrade mode
lcawl Feb 19, 2019
84dbc8a
[DOCS] Teardown example
lcawl Feb 19, 2019
bd930fa
[DOCS] Fixes placement of teardown
lcawl Feb 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/reference/upgrade/close-ml.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@ prevent new jobs from opening, use the <<ml-set-upgrade-mode,set upgrade mode AP
POST _ml/set_upgrade_mode?enabled=true
--------------------------------------------------
// CONSOLE
// TEARDOWN
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this transforms this snippet from a test into a thing that modifies tests on this page. But there aren't tests on this page. So I think this just makes this snippet not run.

I think something like

////////////
Take us out of upgrade mode after running any snippets on this page.

[source,js]
--------------------------------------------------
POST _ml/set_upgrade_mode?enabled=false
--------------------------------------------------
// CONSOLE
// TEARDOWN
////////////

Will run the snippet and always clean up.


This method does not persist the absolute latest model state, rather it uses the
last model state that was automatically saved. By halting the tasks, you avoid
incurring the cost of managing active jobs during the upgrade and it's quicker
than stopping {dfeeds} and closing jobs.
than stopping {dfeeds} and closing jobs.