Don't Ping on Handshake Connection #39076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It does not make sense to run pings on the handshake connection * Set the ping interval to `-1` to deactivate pings on it
original-brownbear
added
>non-issue
:Distributed Coordination/Network
|
Pinging @elastic/es-distributed |
DaveCTurner
reviewed
Feb 19, 2019
There was a problem hiding this comment.
The only other place we use buildSingleChannelProfile(TransportRequestOptions.Type, TimeValue, TimeValue) is in UnicastZenPing. I think this should be adjusted similarly (it's used in Zen1IT today) and we can then remove that overload entirely. Also buildSingleChannelProfile(TransportRequestOptions.Type, boolean) is unused.
Oh wait, that's gone in |
|
@DaveCTurner alright, adjusted the other spot as well and removed the unused overloads :) |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Feb 27, 2019
* Don't Ping on Handshake Connection * It does not make sense to run pings on the handshake connection * Set the ping interval to `-1` to deactivate pings on it
original-brownbear
added a commit
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-1to deactivate pings on it