Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail bwc check if these are disabled #38919

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Don't fail bwc check if these are disabled #38919

merged 1 commit into from
Feb 26, 2019

Conversation

alpar-t
Copy link
Contributor

@alpar-t alpar-t commented Feb 14, 2019

With this change the bwc check on PRs will turn green if bwc tests are disabled.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

mark-vieira
mark-vieira approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This at least goes back to the previous behavior, so we are no worse when it comes to test coverage. There is the existing concern that the BWC PR check returns green, implying those tests ran but we can discuss solutions for that.

@jasontedor jasontedor mentioned this pull request Feb 25, 2019
Merged
@alpar-t alpar-t merged commit ec00ae1 into elastic:master Feb 26, 2019
alpar-t added a commit that referenced this pull request Feb 26, 2019
@alpar-t
Don't fail bwc check if these are disabled (#38919)
1f5aa09
@alpar-t alpar-t deleted the skip-bwcTestSample-if-disabled branch February 26, 2019 07:19
alpar-t added a commit that referenced this pull request Feb 26, 2019
@alpar-t
Don't fail bwc check if these are disabled (#38919)
0b72a70
alpar-t added a commit that referenced this pull request Feb 26, 2019
@alpar-t
Don't fail bwc check if these are disabled (#38919)
b40628f
alpar-t added a commit that referenced this pull request Feb 26, 2019
@alpar-t
Don't fail bwc check if these are disabled (#38919)
51551b7
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-vieira mark-vieira mark-vieira approved these changes

Assignees

@jasontedor jasontedor

Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v6.6.0 v6.7.0 v7.0.0-rc2 v7.2.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alpar-t @elasticmachine @mark-vieira @jakelandis @jasontedor