Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Edits warning in put watch API #38582

Merged
merged 1 commit into from
Feb 15, 2019
Merged

[DOCS] Edits warning in put watch API #38582

merged 1 commit into from
Feb 15, 2019

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Feb 7, 2019

Related to #38509 (comment)

This PR updates a warning in the put watch API reference to clearly indicate that either Kibana or the API can be used. It also replaces some out-dated URL attributes.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl
Copy link
Contributor Author

lcawl commented Feb 8, 2019

Verified that ./gradlew -p x-pack/docs check completes successfully

@lcawl
Copy link
Contributor Author

lcawl commented Feb 8, 2019

Jenkins, test this

1 similar comment
@lcawl
Copy link
Contributor Author

lcawl commented Feb 12, 2019

Jenkins, test this

@lcawl lcawl merged commit faa838c into elastic:master Feb 15, 2019
@lcawl lcawl deleted the put-watch branch February 15, 2019 17:37
lcawl added a commit that referenced this pull request Feb 15, 2019
lcawl added a commit that referenced this pull request Feb 15, 2019
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 15, 2019
* master:
  Address some CCR REST test case flakiness (elastic#38975)
  Edits to text in Completion Suggester doc (elastic#38980)
  SQL: doc polishing
  [DOCS] Fixes broken formatting
  SQL: Polish the rest chapter (elastic#38971)
  Remove `nGram` and  `edgeNGram` token filter names (elastic#38911)
  Add an exception throw if waiting on transport port file fails (elastic#37574)
  Improve testcluster distribution artifact handling (elastic#38933)
  Advance max_seq_no before add operation to Lucene (elastic#38879)
  Reduce global checkpoint sync interval in disruption tests (elastic#38931)
  [test] disable packaging tests for suse boxes
  Relax testStressMaybeFlushOrRollTranslogGeneration (elastic#38918)
  [DOCS] Edits warning in put watch API (elastic#38582)
  Fix serialization bug in ShardFollowTask after cutting this class over to extend from ImmutableFollowParameters.
  [DOCS] Updates methods for upgrading machine learning (elastic#38876)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants