Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of types removal for Put/Get index templates #38465

Merged
merged 15 commits into from
Feb 6, 2019

Conversation

markharwood
Copy link
Contributor

(This is a retry of #38022 - nothing has changed in this 6.x PR but we have since aligned master to be compatible thanks to #38396 and #38431)

Backport of PR #37484

  1. The 7.0 changes in Types removal - deprecate include_type_name with index templates #37484, unchanged
  2. The tweaks to adjust for 6.7 deprecation policies.

@markharwood markharwood added :Search Foundations/Mapping Index mappings, including merging and defining field types backport v6.7.0 labels Feb 5, 2019
@markharwood markharwood self-assigned this Feb 5, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

…stic#37484)

Added deprecation warnings for use of include_type_name in put/get index templates.
HLRC changes:
GetIndexTemplateRequest has a new client-side class which is a copy of server's GetIndexTemplateResponse but modified to be typeless.
PutIndexTemplateRequest has a new client-side counterpart which doesn't use types in the mappings
Relates to elastic#35190
…back ported 7.x changes with the 6.x-specific deprecation policies.

Hopefully this makes review easier by not lumping in with all the 7.x code
…e). Felt a little trappy to have my =false setting ignored.
Other fixes for review comments
Updated 6.x test expectations
@markharwood markharwood force-pushed the fix/35190TemplateDepv6Retry branch from 80f5107 to 3d2454c Compare February 5, 2019 22:41
@jtibshirani jtibshirani merged commit 9f3b3b4 into elastic:6.x Feb 6, 2019
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 6, 2019
* 6.x: (25 commits)
  Backport of types removal for Put/Get index templates (elastic#38465)
  Add support for API keys to access Elasticsearch (elastic#38291) (elastic#38399)
  Deprecate support for internal versioning for concurrency control (elastic#38451)
  Deprecate types in rollover index API (elastic#38389) (elastic#38458)
  Add typless client side GetIndexRequest calls and response class (elastic#38422)
  [ML] Report index unavailable instead of waiting for lazy node (elastic#38444)
  await fix CurtIT#testIndex until elastic#38451 is merged (elastic#38466)
  Update ilm-api.asciidoc, point to REMOVE policy (elastic#38235) (elastic#38464)
  SQL: Fix esType for DATETIME/DATE and INTERVALS (elastic#38179)
  Clean up duplicate follow config parameter code (elastic#37688) (elastic#38443)
  Deprecation check for No Master Block setting (elastic#38383)
  Bubble-up exceptions from scheduler (elastic#38441)
  Lift retention lease expiration to index shard (elastic#38391)
  Deprecate maxRetryTimeout in RestClient and increase default value (elastic#38425)
  Update Rollup Caps to allow unknown fields (elastic#38446)
  Backport of elastic#38411: `if_seq_no` and `if_primary_term` parameters aren't wired correctly in REST Client's CRUD API
  Support unknown fields in ingest pipeline map configuration (elastic#38429)
  SQL: Implement CURRENT_DATE (elastic#38175)
  Backport changes to the release notes script. (elastic#38346)
  Fix ILM explain response to allow unknown fields (elastic#38363)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Search Foundations/Mapping Index mappings, including merging and defining field types v6.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants