Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Add explanation so far to file structure finder exceptions #38191

Conversation

droberts195
Copy link
Contributor

The explanation so far can be invaluable for troubleshooting
as incorrect decisions made early on in the structure analysis
can result in seemingly crazy decisions or timeouts later on.

Relates elastic/kibana#29821

The explanation so far can be invaluable for troubleshooting
as incorrect decisions made early on in the structure analysis
can result in seemingly crazy decisions or timeouts later on.

Relates elastic/kibana#29821
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Even though it is not ideal to hijack the suppressed exceptions mechanism to provide access to the explanation, it seems to be the lesser evil into providing valuable feedback to the users.

@droberts195 droberts195 merged commit fb6a176 into elastic:master Feb 4, 2019
@droberts195 droberts195 deleted the explanation_so_far_in_structure_exception branch February 4, 2019 14:32
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Feb 4, 2019
…tic#38191)

The explanation so far can be invaluable for troubleshooting
as incorrect decisions made early on in the structure analysis
can result in seemingly crazy decisions or timeouts later on.

Relates elastic/kibana#29821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants