Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.2] [Docs] Add example for updating meta field (#35893) #38006

Merged
merged 3 commits into from
Feb 11, 2019
Merged

[6.2] [Docs] Add example for updating meta field (#35893) #38006

merged 3 commits into from
Feb 11, 2019

Conversation

geekpete
Copy link
Member

Backports the following commits to 6.2:

@lcawl
Copy link
Contributor

lcawl commented Feb 1, 2019

The failure of the docs checks in this branch are expected per https://github.com/elastic/infra/issues/8316

@lcawl
Copy link
Contributor

lcawl commented Feb 1, 2019

When I run ./gradlew -p docs check locally, it fails with this error:

...
1> [2019-01-31T16:59:46,636][INFO ][o.e.s.DocsClientYamlTestSuiteIT] [test > {yaml=reference/mapping/fields/meta-field/line_9}]: before test
1> [2019-01-31T16:59:46,855][INFO ][o.e.s.DocsClientYamlTestSuiteIT] Stash dump on test failure [{
1> "stash" : {
1> "body" : {
1> "error" : {
1> "root_cause" : [
1> {
1> "type" : "illegal_argument_exception",
1> "reason" : "Rejecting mapping update to [my_index] as the final mapping would have more than 1 type: [_doc, user]",
1> "stack_trace" : "[Rejecting mapping update to [my_index] as the final mapping would have more than 1 type: [_doc, user]]; nested: IllegalArgumentException[Rejecting mapping update to [my_index] as the final mapping would have more than 1 type: [_doc, user]];

I get the same error when I try running the new example against Elasticsearch 6.2.5 locally.

@lcawl
Copy link
Contributor

lcawl commented Feb 1, 2019

The book itself builds fine, however, using the docbldesold alias in https://github.com/elastic/docs/blob/master/doc_build_aliases.sh

@geekpete
Copy link
Member Author

geekpete commented Feb 5, 2019

Looks like I need to adjust for the older version where the type should be /doc and not /_doc, so I'll fix that.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds successfully (with docbldes alias)

@lcawl lcawl merged commit 434e1a2 into elastic:6.2 Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants