Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure task metadata not null in follow test #37993

Merged
merged 1 commit into from
Jan 29, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Ensure task metadata not null in follow test
This commit fixes a potential race in the IndexFollowingIT. Currently it
is possible that we fetch the task metadata, it is null, and that throws
a null pointer exception. Assertbusy does not catch null pointer
exceptions. This commit assertions that the metadata is not null.
Tim-Brooks committed Jan 29, 2019

Unverified

This user has not yet uploaded their public signing key.
commit 16411398249da335692e038e7d678ab64f182e85
Original file line number Diff line number Diff line change
@@ -983,6 +983,7 @@ private CheckedRunnable<Exception> assertTask(final int numberOfPrimaryShards, f
return () -> {
final ClusterState clusterState = followerClient().admin().cluster().prepareState().get().getState();
final PersistentTasksCustomMetaData taskMetadata = clusterState.getMetaData().custom(PersistentTasksCustomMetaData.TYPE);
assertNotNull(taskMetadata);

ListTasksRequest listTasksRequest = new ListTasksRequest();
listTasksRequest.setDetailed(true);