Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the how-to section of the docs for 7.0: #37717

Merged
merged 7 commits into from
Mar 12, 2019

Conversation

jpountz
Copy link
Contributor

@jpountz jpountz commented Jan 22, 2019

  • new feature/script_score queries
  • new index_phrases/index_prefixes options
  • disabling _field_names doesn't help anymore
  • adaptive replica selection is on by default

 - new `feature`/`script_score` queries
 - new `index_phrases`/`index_prefixes` options
 - disabling `_field_names` doesn't help anymore
 - adaptive replica selection is on by default
@jpountz jpountz added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories v7.0.0 labels Jan 22, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@jasontedor jasontedor added v8.0.0 and removed v7.0.0 labels Feb 6, 2019
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left two comments where I'd like to confirm my understanding and two very minor suggestions to rephrase something. Please feel free to disregard those.

=== Faster phrase queries with `index_phrases`

The <<text,`text`>> field has an <<index-phrases,`index_phrases`>> option that
pre-indexes 2-shingles at index-time and is automatically leveraged by query
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: just a matter of taste I guess, but I find "pre-indexes ... at index-time" is a bit redundant (especially the pre). Maybe "indexes 2-shingles" or "already adds 2-shingles at index-time" is enough?

=== Faster prefix queries with `index_prefixes`

The <<text,`text`>> field has an <<index-phrases,`index_prefixes`>> option that
pre-indexes prefixes of all terms at index-time and is automatically leveraged
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: same here


The <<mapping-field-names-field,`_field_names` field>> introduces some
index-time overhead, so you might want to disable it if you never need to
run `exists` queries.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, this is removed because indexing this field doesn't have the index overhead it once did?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. @colings86 made things better in #26930 and we now use doc values or norms to run queries most-of-time, and only index into the _field_names field when doc values are not enabled (either because the user disabled them or because the field doesn't support doc values).

criteria called <<search-adaptive-replica,adaptive replica selection>> to select
the best copy of the data based on response time, service time, and queue size
of the node containing each copy of the shard. This can improve query throughput
and reduce latency for search-heavy applications.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also just to confirm, this is removed because adaptive replica selection is now the default?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct.

@jpountz jpountz merged commit 8905d77 into elastic:master Mar 12, 2019
@jpountz jpountz deleted the fix/howto-docs-7 branch March 12, 2019 07:23
jpountz added a commit that referenced this pull request Mar 12, 2019
 - new `rank_feature`/`script_score` queries
 - new `index_phrases`/`index_prefixes` options
 - disabling `_field_names` doesn't help anymore
 - adaptive replica selection is on by default
jpountz added a commit that referenced this pull request Mar 12, 2019
 - new `rank_feature`/`script_score` queries
 - new `index_phrases`/`index_prefixes` options
 - disabling `_field_names` doesn't help anymore
 - adaptive replica selection is on by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants