-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the how-to section of the docs for 7.0: #37717
Conversation
- new `feature`/`script_score` queries - new `index_phrases`/`index_prefixes` options - disabling `_field_names` doesn't help anymore - adaptive replica selection is on by default
Pinging @elastic/es-search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left two comments where I'd like to confirm my understanding and two very minor suggestions to rephrase something. Please feel free to disregard those.
=== Faster phrase queries with `index_phrases` | ||
|
||
The <<text,`text`>> field has an <<index-phrases,`index_phrases`>> option that | ||
pre-indexes 2-shingles at index-time and is automatically leveraged by query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: just a matter of taste I guess, but I find "pre-indexes ... at index-time" is a bit redundant (especially the pre). Maybe "indexes 2-shingles" or "already adds 2-shingles at index-time" is enough?
=== Faster prefix queries with `index_prefixes` | ||
|
||
The <<text,`text`>> field has an <<index-phrases,`index_prefixes`>> option that | ||
pre-indexes prefixes of all terms at index-time and is automatically leveraged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: same here
|
||
The <<mapping-field-names-field,`_field_names` field>> introduces some | ||
index-time overhead, so you might want to disable it if you never need to | ||
run `exists` queries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, this is removed because indexing this field doesn't have the index overhead it once did?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. @colings86 made things better in #26930 and we now use doc values or norms to run queries most-of-time, and only index into the _field_names
field when doc values are not enabled (either because the user disabled them or because the field doesn't support doc values).
criteria called <<search-adaptive-replica,adaptive replica selection>> to select | ||
the best copy of the data based on response time, service time, and queue size | ||
of the node containing each copy of the shard. This can improve query throughput | ||
and reduce latency for search-heavy applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also just to confirm, this is removed because adaptive replica selection is now the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct.
- new `rank_feature`/`script_score` queries - new `index_phrases`/`index_prefixes` options - disabling `_field_names` doesn't help anymore - adaptive replica selection is on by default
- new `rank_feature`/`script_score` queries - new `index_phrases`/`index_prefixes` options - disabling `_field_names` doesn't help anymore - adaptive replica selection is on by default
feature
/script_score
queriesindex_phrases
/index_prefixes
options_field_names
doesn't help anymore