Fix a test failure in CompositeRolesStoreTests #37661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to missing stubbing for `NativePrivilegeStore#getPrivileges` the test `testNegativeLookupsAreCached` failed when the superuser role name was present in the role names. This commit adds missing stubbing. Closes: elastic#37657
bizybot
added
>test-failure
|
Pinging @elastic/es-security |
|
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-2/5221/console
run gradle build tests 1 |
|
run gradle build tests 2 |
bizybot
added a commit
to bizybot/elasticsearch
that referenced
this pull request
Jan 21, 2019
Due to missing stubbing for `NativePrivilegeStore#getPrivileges` the test `testNegativeLookupsAreCached` failed when the superuser role name was present in the role names. This commit adds missing stubbing. Closes: elastic#37657
bizybot
pushed a commit
to bizybot/elasticsearch
that referenced
this pull request
Jan 22, 2019
The PR for the fix has been merged. elastic#37661 but the awaits fix annotation was not removed.
bizybot
added a commit
that referenced
this pull request
Jan 22, 2019
The PR for the fix has been merged. #37661 but the awaits fix annotation was not removed.
bizybot
added a commit
that referenced
this pull request
Jan 22, 2019
The PR for the fix has been merged. #37661 but the awaits fix annotation was not removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to missing stubbing for
NativePrivilegeStore#getPrivilegesthe test
testNegativeLookupsAreCachedfailedwhen the superuser role name was present in the role names.
This commit adds missing stubbing.
Closes: #37657