Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to use the resolved type in DocumentMapperService#extractMappings. #37451

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Make sure to use the resolved type in DocumentMapperService#extractMappings. #37451

merged 2 commits into from
Jan 15, 2019

Conversation

jtibshirani
Copy link
Contributor

  • Pull out a shared method MapperService#resolveDocumentType.
  • Make sure to resolve the type when extracting the mappings.

Addresses #36811.

@jtibshirani
Make sure to use the resolved type in DocumentMapperService#extractMa…
eaae24c 
…ppings.

* Pull out a shared method MapperService#resolveDocumentType.
* Make sure to resolve the type when extracting the mappings.

Addresses elastic#36811.
@jtibshirani jtibshirani added >bug :Search Foundations/Mapping Index mappings, including merging and defining field types v7.0.0 labels Jan 15, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@jtibshirani
Copy link
Contributor Author

@jpountz this really didn't turn out as cleanly as I hoped -- feel free to make changes, or open a new PR instead.

@jtibshirani jtibshirani requested a review from jpountz January 15, 2019 06:19
jpountz
jpountz approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I don't have better ideas... Thanks for tackling it!

@jtibshirani
Copy link
Contributor Author

jtibshirani commented Jan 15, 2019 •
edited
Loading

Thanks for the review! As a note I filed #37450 to track cleaning up the overall approach.

@jtibshirani jtibshirani merged commit 1a1dbf7 into elastic:master Jan 15, 2019
@jtibshirani jtibshirani deleted the mix-typeless-and-typed branch January 15, 2019 15:32
@jtibshirani jtibshirani mentioned this pull request Jan 15, 2019
Closed
@jtibshirani jtibshirani removed the WIP label Jan 15, 2019
@jtibshirani jtibshirani mentioned this pull request Jan 15, 2019
Closed
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpountz jpountz jpountz approved these changes

Assignees
No one assigned
Labels
>bug :Search Foundations/Mapping Index mappings, including merging and defining field types v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtibshirani @elasticmachine @jpountz @colings86