Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add set_priority action to ILM #37397

Merged
merged 9 commits into from
Jan 17, 2019
Merged

Add set_priority action to ILM #37397

merged 9 commits into from
Jan 17, 2019

Conversation

jakelandis
Copy link
Contributor

This commit adds a set_priority action to the hot, warm, and cold
phases for an ILM policy. This action sets the index.priority
on the managed index to allow different priorities between the
hot, warm, and cold recoveries.

This commit also includes the HLRC and documentation changes.

closes #36905

@jakelandis
Add set_priority action to ILM
2f78f8e 
This commit adds a set_priority action to the hot, warm, and cold
phases for an ILM policy. This action sets the `index.priority`
on the managed index to allow different priorities between the
hot, warm, and cold recoveries.

This commit also includes the HLRC and documentation changes.

closes elastic#36905
@jakelandis jakelandis added >enhancement v7.0.0 :Data Management/ILM+SLM Index and Snapshot lifecycle management v6.7.0 labels Jan 13, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

dakrone
dakrone requested changes Jan 14, 2019
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this @jakelandis, I left some comments

...rest-high-level/src/main/java/org/elasticsearch/client/indexlifecycle/SetPriorityAction.java Outdated Show resolved Hide resolved
...rest-high-level/src/main/java/org/elasticsearch/client/indexlifecycle/SetPriorityAction.java Outdated Show resolved Hide resolved
...rest-high-level/src/main/java/org/elasticsearch/client/indexlifecycle/SetPriorityAction.java Outdated Show resolved Hide resolved
...high-level/src/test/java/org/elasticsearch/client/indexlifecycle/SetPriorityActionTests.java Show resolved Hide resolved
docs/reference/ilm/policy-definitions.asciidoc Outdated Show resolved Hide resolved
...plugin/core/src/main/java/org/elasticsearch/xpack/core/indexlifecycle/SetPriorityAction.java Outdated Show resolved Hide resolved
...plugin/core/src/main/java/org/elasticsearch/xpack/core/indexlifecycle/SetPriorityAction.java Outdated Show resolved Hide resolved
...plugin/core/src/main/java/org/elasticsearch/xpack/core/indexlifecycle/SetPriorityAction.java Outdated Show resolved Hide resolved
...n/core/src/test/java/org/elasticsearch/xpack/core/indexlifecycle/SetPriorityActionTests.java Show resolved Hide resolved
...-node/src/test/java/org/elasticsearch/xpack/indexlifecycle/TimeSeriesLifecycleActionsIT.java Show resolved Hide resolved
gwbrown
gwbrown requested changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good aside from the stuff Lee brought up, these are mostly nitpicks.

...rest-high-level/src/main/java/org/elasticsearch/client/indexlifecycle/SetPriorityAction.java Outdated Show resolved Hide resolved
...high-level/src/test/java/org/elasticsearch/client/indexlifecycle/SetPriorityActionTests.java Outdated Show resolved Hide resolved
docs/reference/ilm/policy-definitions.asciidoc Outdated Show resolved Hide resolved
docs/reference/ilm/policy-definitions.asciidoc Outdated Show resolved Hide resolved
...plugin/core/src/main/java/org/elasticsearch/xpack/core/indexlifecycle/SetPriorityAction.java Outdated Show resolved Hide resolved
...rest-high-level/src/main/java/org/elasticsearch/client/indexlifecycle/SetPriorityAction.java Show resolved Hide resolved
@jakelandis
Copy link
Contributor Author

@dakrone @gwbrown Thanks for the reviews! changes implemented and ready for re-review. The only substantial changes are on commit 478891f (support null to unset priority) , the rest of the changes are minor/nits.

dakrone
dakrone approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left 3 minor comments

...high-level/src/test/java/org/elasticsearch/client/indexlifecycle/SetPriorityActionTests.java Show resolved Hide resolved
docs/reference/ilm/policy-definitions.asciidoc Show resolved Hide resolved
...n/core/src/test/java/org/elasticsearch/xpack/core/indexlifecycle/SetPriorityActionTests.java Outdated Show resolved Hide resolved
gwbrown
gwbrown approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me as well, once Lee's remaining comments are addressed and CI is happy.

@jakelandis
Copy link
Contributor Author

@elasticmachine test this please

@jakelandis
Copy link
Contributor Author

@elasticmachine run gradle build tests 1
@elasticmachine run gradle build tests 2

@jakelandis
Copy link
Contributor Author

@elasticmachine run gradle build tests 1

@jakelandis jakelandis merged commit 587034d into elastic:master Jan 17, 2019
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 17, 2019
@jasontedor
Merge remote-tracking branch 'elastic/master' into thread-context-add…
c801d39 
…-response-header-performance

* elastic/master:
  Remove Redundant RestoreRequest Class (elastic#37535)
  Create specific exception for when snapshots are in progress (elastic#37550)
  Mute UnicastZenPingTests#testSimplePings
  [DOCS] Adds size limitation to the get datafeeds APIs (elastic#37578)
  Fix assertion at end of forceRefreshes (elastic#37559)
  Propagate Errors in executors to uncaught exception handler (elastic#36137)
  [DOCS] Adds limitation to the get jobs API (elastic#37549)
  Add set_priority action to ILM (elastic#37397)
  Make recovery source send operations non-blocking (elastic#37503)
  Allow field types to optimize phrase prefix queries (elastic#37436)
  Added fatal_exception field for ccr stats in monitoring mapping. (elastic#37563)
  Fix testRelocateWhileContinuouslyIndexingAndWaitingForRefresh (elastic#37560)
  Moved ccr integration to the package with other ccr integration tests.
  Mute TransportClientNodesServiceTests#testListenerFailures
  Decreased time out in test
  Fix erroneous docstrings for abstract bulk by scroll request (elastic#37517)
  SQL: Rename SQL type DATE to DATETIME (elastic#37395)
  Remove the AbstracLifecycleComponent constructor with Settings (elastic#37523)
jakelandis added a commit that referenced this pull request Jan 17, 2019
@jakelandis
Add set_priority action to ILM (#37397)
df6dd40 
This commit adds a set_priority action to the hot, warm, and cold
phases for an ILM policy. This action sets the `index.priority`
on the managed index to allow different priorities between the
hot, warm, and cold recoveries.

This commit also includes the HLRC and documentation changes.

closes #36905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwbrown gwbrown gwbrown approved these changes

@dakrone dakrone dakrone approved these changes

@talevy talevy Awaiting requested review from talevy

Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >enhancement v6.7.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ILM] rollover + settings.index.priority
5 participants
@jakelandis @elasticmachine @dakrone @gwbrown @colings86