Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Streamable to Writeable for cluster block package #37391

Merged
merged 3 commits into from
Feb 19, 2019

Conversation

liketic
Copy link

@liketic liketic commented Jan 13, 2019

Migrate Streamable to Writeable for cluster block package.

Relates to #34389

@colings86 colings86 added the :Core/Infra/Core Core issues without another label label Jan 14, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdconrad
Copy link
Contributor

@liketic Would you please resolve the conflicts and commit once that is done? Thanks!

@liketic
Copy link
Author

liketic commented Feb 16, 2019

@jdconrad Please review again.

@jdconrad
Copy link
Contributor

@elasticmachine test this please

@jdconrad jdconrad merged commit 106f590 into elastic:master Feb 19, 2019
@jdconrad
Copy link
Contributor

@liketic Thank you for the contribution!

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 20, 2019
…follow

* elastic/master: (37 commits)
  Enable test logging for TransformIntegrationTests#testSearchTransform.
  stronger wording for ilm+rollover in docs (elastic#39159)
  Mute SingleNodeTests (elastic#39156)
  AwaitsFix XPackUsageIT#testXPackCcrUsage.
  Resolve concurrency with watcher trigger service (elastic#39092)
  Fix median calculation in MedianAbsoluteDeviationAggregatorTests (elastic#38979)
  [DOCS] Edits the remote clusters documentation (elastic#38996)
  add version 6.6.2
  Revert "Mute failing test 20_mix_typless_typefull (elastic#38781)" (elastic#38912)
  Rebuild remote connections on profile changes (elastic#37678)
  Document 'max_size' parameter as shard size for rollover (elastic#38750)
  Add some missing toString() implementations (elastic#39124)
  Migrate Streamable to Writeable for cluster block package (elastic#37391)
  fix RethrottleTests retry (elastic#38978)
  Disable date parsing test in non english locale (elastic#39052)
  Remove BCryptTests (elastic#39098)
  [ML] Stop the ML memory tracker before closing node (elastic#39111)
  Allow retention lease operations under blocks (elastic#39089)
  ML refactor DatafeedsConfig(Update) so defaults are not populated in queries or aggs (elastic#38822)
  Fix retention leases sync on recovery test
  ...
@javanna
Copy link
Member

javanna commented Feb 21, 2019

@jdconrad can you add version labels? I guess it would be good if this went to 7.x as well?

@danielmitterdorfer
Copy link
Member

As @jdconrad is out at the moment, I went ahead, added the labels on his behalf and also created #39236 to backport this to 7.x.

@javanna
Copy link
Member

javanna commented Feb 21, 2019

++ thanks @danielmitterdorfer !

@jdconrad
Copy link
Contributor

@danielmitterdorfer Realize this is a bit late -- thanks for backporting!

@danielmitterdorfer
Copy link
Member

No worries @jdconrad. You're welcome. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants