Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fixing duplicate audit messages in delayed data check #37080

Merged

Conversation

benwtrent
Copy link
Member

Fixes the bug where multiple annotations will occur if there is an end time that is different than the timestamp.

Minor other changes as well for consistency with the UI.

closes #36891 #36888 #36889

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@droberts195
Copy link
Contributor

Since there are other blockers open against 6.6.0 I think the complete fix should be backported into 6.6.0. It would be best if this new functionality didn’t start off with a reputation for spamming users.

Also, please change the PR title to something that makes sense as a standalone sentence for the release notes.

@benwtrent benwtrent changed the title addressing (#36891)(#36888)(#36889) Fixing duplicate audit messages in delayed data check Jan 2, 2019
@benwtrent
Copy link
Member Author

run the gradle build tests 1

1 similar comment
@benwtrent
Copy link
Member Author

run the gradle build tests 1

@dimitris-athanasiou dimitris-athanasiou changed the title Fixing duplicate audit messages in delayed data check [ML] Fixing duplicate audit messages in delayed data check Jan 3, 2019
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Delayed data annotation - repeated audit messages
5 participants