Update transport docs and settings for changes #36786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Brooks
added
>docs
|
Pinging @elastic/es-distributed |
Tim-Brooks
changed the title
lcawl
reviewed
Dec 18, 2018
| @@ -161,6 +161,14 @@ PUT _cluster/settings | |||
| are sent according to the global `transport.ping_schedule` setting, which | |||
| defaults to ``-1` meaning that pings are not sent. | |||
|
|
|||
| `cluster.remote.${cluster_alias}.transport.compress`:: | |||
|
|
|||
| Per cluster boolean setting that allows compression to be configured for | |||
There was a problem hiding this comment.
Suggested change
| Per cluster boolean setting that allows compression to be configured for | |
| Per cluster boolean setting that enables you to configure compression for |
lcawl
reviewed
Dec 18, 2018
| `cluster.remote.${cluster_alias}.transport.compress`:: | ||
|
|
||
| Per cluster boolean setting that allows compression to be configured for | ||
| requests to a specific remote cluster. This setting only impacts requests |
There was a problem hiding this comment.
Suggested change
| requests to a specific remote cluster. This setting only impacts requests | |
| requests to a specific remote cluster. This setting impacts only requests |
lcawl
reviewed
Dec 18, 2018
|
|
||
| Per cluster boolean setting that allows compression to be configured for | ||
| requests to a specific remote cluster. This setting only impacts requests | ||
| sent to the remote cluster. Elasticsearch will compress a response if the |
There was a problem hiding this comment.
Suggested change
| sent to the remote cluster. Elasticsearch will compress a response if the | |
| sent to the remote cluster. If the |
lcawl
reviewed
Dec 18, 2018
| Per cluster boolean setting that allows compression to be configured for | ||
| requests to a specific remote cluster. This setting only impacts requests | ||
| sent to the remote cluster. Elasticsearch will compress a response if the | ||
| inbound request was compressed. If unset, the global `transport.compress` |
There was a problem hiding this comment.
Suggested change
| inbound request was compressed. If unset, the global `transport.compress` | |
| inbound request is compressed, Elasticsearch compresses the response. If unset, the global `transport.compress` |
lcawl
reviewed
Dec 18, 2018
|
|
||
| The TCP transport is an implementation of the transport module using | ||
| TCP. It allows for the following settings: | ||
| The internal transport communicates over TCP. It allows for the following |
There was a problem hiding this comment.
Suggested change
| The internal transport communicates over TCP. It allows for the following | |
| The internal transport communicates over TCP. You can configure it with the following |
|
I marked this for 6.7 too. The new settings exist starting 6.6. So it seems reasonable to update the doc for the new settings in 6.7. |
lcawl
approved these changes
Dec 18, 2018
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Dec 19, 2018
Commit elastic#36786 updated docs and strings to reference transport.port instead of transport.tcp.port. However, this breaks backwards compatibility tests as the tests rely on string configurations and transport.port does not exist prior to 6.6. This commit reverts the places were we reference transport.tcp.port for tests. This work will need to be reintroduced in a backwards compatible way.
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Dec 19, 2018
Commit elastic#36786 updated docs and strings to reference transport.port instead of transport.tcp.port. However, this breaks backwards compatibility tests as the tests rely on string configurations and transport.port does not exist prior to 6.6. This commit reverts the places were we reference transport.tcp.port for tests. This work will need to be reintroduced in a backwards compatible way.
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Dec 20, 2018
This is related to elastic#36652. In 7.0 we plan to deprecate a number of settings that make reference to the concept of a tcp transport. We mostly just have a single transport type now (based on tcp). Settings should only reference tcp if they are referring to socket options. This commit updates the settings in the docs. And removes string usages of the old settings. Additionally it adds a missing remote compress setting to the docs.
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Dec 20, 2018
Commit elastic#36786 updated docs and strings to reference transport.port instead of transport.tcp.port. However, this breaks backwards compatibility tests as the tests rely on string configurations and transport.port does not exist prior to 6.6. This commit reverts the places were we reference transport.tcp.port for tests. This work will need to be reintroduced in a backwards compatible way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #36652. In 7.0 we plan to deprecate a number of
settings that make reference to the concept of a
tcp transport. Wemostly just have a single transport type now (based on tcp). Settings
should only reference tcp if they are referring to socket options. This
commit updates the settings in the docs. And removes string usages of
the old settings. Additionally it adds a missing remote compress setting
to the docs.