-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the MockTcpTransport
#36628
Merged
Tim-Brooks
merged 5 commits into
elastic:master
from
Tim-Brooks:remove_mock_tcp_transport
Dec 14, 2018
Merged
Remove the MockTcpTransport
#36628
Tim-Brooks
merged 5 commits into
elastic:master
from
Tim-Brooks:remove_mock_tcp_transport
Dec 14, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Brooks
added
>test
Issues or PRs that are addressing/adding tests
:Distributed Coordination/Network
Http and internode communication implementations
v7.0.0
labels
Dec 14, 2018
Pinging @elastic/es-distributed |
run gradle build tests 1 |
original-brownbear
approved these changes
Dec 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, test failure looks unrelated
@elasticmachine run gradle build tests 1 |
s1monw
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Network
Http and internode communication implementations
>test
Issues or PRs that are addressing/adding tests
v7.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes all remaining usages of the
MockTcpTransport
.Additionally it removes the
MockTcpTransport
and its test case.