Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the MockTcpTransport #36628

Merged
merged 5 commits into from
Dec 14, 2018

Conversation

Tim-Brooks
Copy link
Contributor

This commit removes all remaining usages of the MockTcpTransport.
Additionally it removes the MockTcpTransport and its test case.

@Tim-Brooks Tim-Brooks added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Network Http and internode communication implementations v7.0.0 labels Dec 14, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@Tim-Brooks
Copy link
Contributor Author

run gradle build tests 1

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test failure looks unrelated

@original-brownbear
Copy link
Member

@elasticmachine run gradle build tests 1

@Tim-Brooks Tim-Brooks merged commit fbf88b2 into elastic:master Dec 14, 2018
@Tim-Brooks Tim-Brooks deleted the remove_mock_tcp_transport branch December 19, 2018 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Network Http and internode communication implementations >test Issues or PRs that are addressing/adding tests v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants