Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] fix SecurityDocumentationIT#testGetUsers #36622

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Dec 13, 2018

this test was failing because of two reason

  • it was creating invalid users with passwords shorter than 6 characters
  • it was expecting 7 total users to be returned, but it should be 9

relates to #36332

this test was failing because of two reason
- it was creating invalid users with passwords shorter than 6 characters
- it was expecting 7 total users to be returned, but it should be 9
@talevy talevy added >docs General docs changes >test Issues or PRs that are addressing/adding tests :Core/Features/Java High Level REST Client labels Dec 13, 2018
@talevy talevy requested a review from nknize December 13, 2018 23:21
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@bleskes
Copy link
Contributor

bleskes commented Dec 14, 2018

I'm merging this. No need to wait with these kind of prs. Just push as the build is red anyway until you do.

@bleskes bleskes merged commit 8a85798 into elastic:master Dec 14, 2018
@talevy
Copy link
Contributor Author

talevy commented Dec 14, 2018

thanks @bleskes

@talevy talevy deleted the fix-security-doc-test branch December 14, 2018 16:25
tvernum pushed a commit that referenced this pull request Dec 17, 2018
this test was failing because of two reason
- it was creating invalid users with passwords shorter than 6 characters
- it was expecting 7 total users to be returned, but it should be 9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes >test Issues or PRs that are addressing/adding tests v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants