[ML] Full cluster restart tests for migration #36593
Conversation
|
Pinging @elastic/ml-core |
|
run gradle build tests 2 |
davidkyle
force-pushed
the
migration-full-cluster-restart-tests
branch
from
6dc37a7 to
aabbdee
Compare
| assertEquals("opened", XContentMapValues.extractValue("state", jobStats.get(0))); | ||
| assertThat((String)XContentMapValues.extractValue("assignment_explanation", jobStats.get(0)), isEmptyOrNullString()); | ||
| assertNotNull(XContentMapValues.extractValue("node", jobStats.get(0))); | ||
| } catch (IOException e) { |
There was a problem hiding this comment.
Why do we need to ignore IOExceptions here?
There was a problem hiding this comment.
Well the assert busy will retry and eventually timeout, either way the test will fail but I admit the cause will be lost
There was a problem hiding this comment.
I don't do it elsewhere I'll clean that up
There was a problem hiding this comment.
I think an exception other than an AssertionError will stop the busy loop. So if an IOException can be thrown that shouldn't terminate the busy loop then it needs to be caught here. But maybe there isn't.
There was a problem hiding this comment.
Yes assert busy only catches AssertionError and the IOException should fail the test and not be caught here. I'm gonna blame intellij and remove the try...catch
Similar to the upgrade tests in #36425
Creates jobs in the old cluster opening one of them, then in the upgraded cluster asserts that the closed jobs have been migrated and can be opened. Asserts that jobs left open during upgrade get an assignment