Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adapt to periodic persistent task refresh #36494

Conversation

droberts195
Copy link
Contributor

Feature branch PR

If #36069 is
merged then the approach for reallocating ML persistent tasks
after refreshing job memory requirements can be simplified.
This change begins the simplification process.

Currently WIP as #36069
is not merged.

If https://github.com/elastic/elasticsearch/pull/36069/files is
merged then the approach for reallocating ML persistent tasks
after refreshing job memory requirements can be simplified.
This change begins the simplification process.
@droberts195 droberts195 added WIP :ml Machine learning labels Dec 11, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -183,6 +183,7 @@ public void testCloseUnassignedJobAndDatafeed() throws Exception {
}

@TestLogging("org.elasticsearch.xpack.ml.action:TRACE,org.elasticsearch.xpack.ml.process:TRACE")
@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/pull/36069")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be removed in the next PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I'll get that working before merging this PR.

@davidkyle
Copy link
Member

run gradle build tests 2

@droberts195 droberts195 merged commit e0a58c9 into elastic:feature-jindex-6x Dec 14, 2018
@droberts195 droberts195 deleted the adapt_to_periodic_task_refresh branch December 14, 2018 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants