Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ILM] fix ilm.remove_policy rest-spec #36165

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Dec 3, 2018

The rest interface for remove-policy-from-index API does not support
_ilm/remove, it requires that an {index} pattern be defined in
the URL path. This fixes the rest-api-spec to reflect the implementation

reference:

controller.registerHandler(RestRequest.Method.POST, "/{index}/_ilm/remove", this);

The rest interface for remove-policy-from-index API does not support
`_ilm/remove`, it requires that an `{index}` pattern be defined in
the URL path. This fixes the rest-api-spec to reflect the implementation
@talevy talevy added the :Data Management/ILM+SLM Index and Snapshot lifecycle management label Dec 3, 2018
@talevy talevy requested review from colings86 and gwbrown December 3, 2018 16:56
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@talevy
Copy link
Contributor Author

talevy commented Dec 3, 2018

cc @bmcconaghy

Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment above (comment deleted as not relevant since I misread the description above)

@colings86 colings86 dismissed their stale review December 3, 2018 17:01

not relevant

Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talevy talevy merged commit fdec331 into elastic:master Dec 3, 2018
@talevy talevy deleted the ilm-rest-spec branch December 3, 2018 18:55
talevy added a commit that referenced this pull request Dec 3, 2018
The rest interface for remove-policy-from-index API does not support
`_ilm/remove`, it requires that an `{index}` pattern be defined in
the URL path. This fixes the rest-api-spec to reflect the implementation
spinscale pushed a commit that referenced this pull request Dec 4, 2018
The rest interface for remove-policy-from-index API does not support
`_ilm/remove`, it requires that an `{index}` pattern be defined in
the URL path. This fixes the rest-api-spec to reflect the implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants