-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HLRC] Fix issue in equals impl for GlobalOperationPrivileges #35721
Conversation
This commit fixes an issue in the equals implementation for GlobalOperationPrivileges and adds few tests.
Pinging @elastic/es-security |
...rc/main/java/org/elasticsearch/client/security/user/privileges/GlobalOperationPrivilege.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/client/security/user/privileges/GlobalOperationPrivilege.java
Outdated
Show resolved
Hide resolved
...st/java/org/elasticsearch/client/security/user/privileges/GlobalOperationPrivilegeTests.java
Show resolved
Hide resolved
I've left some comments. You've touched my purist decisions so I am curious if the status quo broke something in order to possibly revision my stance. |
- Revert unwanted code changes
Hi @albertzaharovits I have addressed the comments by removing the unwanted code changes, keeping those relevant to the fix I thought was needed in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit fixes an issue in the equals implementation for GlobalOperationPrivileges and adds few tests.
This commit fixes an issue in the equals implementation for
GlobalOperationPrivileges and adds few tests.